Continuous integration builds have changed state:
Travis build 4109. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/439709708.
Appveyor build 3904. State: success. Details:
Review: Approve
At least the style is consistent now. I think the difference to the frisians is
good for the player to distinguish between them easily.
Thanks a lot
--
https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221
Your team Widelands Developers is subscribed to
* Source Package: widelands
* Version: 1:19-ppa0-bzr8875-201810101704~ubuntu14.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 3 minutes
* Build Log:
* Source Package: widelands
* Version: 1:19-ppa0-bzr8875-201810101704~ubuntu14.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 3 minutes
* Build Log:
Good catch!
^ means the string has to be at the beginning. Without it is also possible to
call the url '/fooprivacy/' which is not what is wanted.
Thanks a lot for the review :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/privacy_policy/+merge/356282
Your team Widelands
You keep calling that a feature, while it is mostly a fix for the long-standing
poor scheduling, so technically it still applies despite the feature freeze.
Furthermore, the freeze was announced on 2018-09-17, while this branch has been
approved on 2018-09-14. The late problems with the test
Review: Approve
LGTM - just 1 comment for a potential bug
Diff comments:
>
> === modified file 'urls.py'
> --- urls.py 2018-09-12 07:45:35 +
> +++ urls.py 2018-10-09 18:02:37 +
> @@ -58,6 +58,7 @@
> url(r'^ggz/', include('wlggz.urls')),
> url(r'^moderated/',
Review: Approve
LGTM, just 1 tiny nit - we have an extra indent that we could lose
Diff comments:
>
> === modified file 'threadedcomments/views.py'
> --- threadedcomments/views.py 2018-04-05 07:30:42 +
> +++ threadedcomments/views.py 2018-10-05 16:44:16 +
> @@ -87,25 +89,19 @@
>
No, I did mean Build 21. We are in feature freeze, and feature freeze means
it's feature freeze for everybody. Otherwise, we'll never get a release out,
because there will always be that one cool feature we'll want to squeeze in.
It's very tempting.
Having an assignee in TODO comment would
Portrait for Murilius is uploaded. He looks a bit different to the Frisian
people though ;)
--
https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fri-portraits.
Continuous integration builds have changed state:
Travis build 4107. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/439517974.
Appveyor build 3902. State: success. Details:
Yes, the empire workers are also in the repo. It´ll still look somewhat
different though due to different modelling style. I´ll make the image this
evening :)
--
https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221
Your team Widelands Developers is subscribed to
the portraits are better now with the canvas texture they don't look that bad
anymore.
Do you have the blender files for the romans as well to create a Screenshot
also for Murilius?
That would give us some consistency over the Frisian campaign
--
I have given the portraits (including Murilius) some editing in GIMP now to
give them a painting-like look and a playercolored frame. How about these?
--
https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221
Your team Widelands Developers is subscribed to branch
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Commit message:
Improved error messages for gl initialize.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Description changed to:
The error message for the shading language version is a bit misleading, so I
did some rework. Also, the dialog box was too wide for my taste.
For more details, see:
16 matches
Mail list logo
