[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fri-portraits into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 -- Your team Widelands Developers is subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands

2018-10-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454 -- Your team Widelands De

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795570-chat-br-tags into lp:widelands

2018-10-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 4118. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/440588155. Appveyor build 3915. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179557

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands

2018-10-12 Thread GunChleoc
Thanks yourself for the savegame! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795976-port-attack-crash. ___ M

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands

2018-10-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1791605-on-failure-fail/+merge/356654 -- Your team Widelands Develo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands

2018-10-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 4117. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/440586787. Appveyor build 3914. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179160

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands

2018-10-12 Thread kaputtnik
Great, thanks :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795976-port-attack-crash. ___ Mailing list: http

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-12 Thread Benedikt Straub
If I may be so bold – I have added the missing dev-credit entry for myself here, and as there are two approves: @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands

2018-10-12 Thread GunChleoc
Review: Approve Tested, bug is fixed :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795976-port-attack-crash. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands

2018-10-12 Thread kaputtnik
Review: Approve The messages are gone. I think this change is uncritical, so: @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1791605-on-failure-fail/+merge/356654 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1791605-on-failur

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmakepolicy into lp:widelands

2018-10-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 4116. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/440557293. Appveyor build 3913. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepolic

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_music into lp:widelands

2018-10-12 Thread Benedikt Straub
@Gun What´s the status here? Will this get into b20? -- https://code.launchpad.net/~widelands-dev/widelands/frisian_music/+merge/350429 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/frisian_music into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands

2018-10-12 Thread TiborB
@Gun, can you look at the diff? I removed your std::set and just look into vector instead. Usually it is <=5 items, so no big overhead I tested with bug's savegame and with a random game from scratch... -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_scheduling_2 into lp:widelands

2018-10-12 Thread GunChleoc
Please stop insulting everybody whenever you don't get your way. Yes, the release cycles are too long. No, we won't solve the problem of managing testing exposure by merging your feature right now this very instant. Changing the release process in the middle of a release is not going to happen,

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands

2018-10-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands. Commit message: Remove test logging output from production_program.cc Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1791605 in widelands: "Warnings for "on f

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795570-chat-br-tags into lp:widelands

2018-10-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1795570-chat-br-tags into lp:widelands. Commit message: Fix br tag in chat server help message Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1795570 in widelands: "Chat /help prints instead of using

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmakepolicy into lp:widelands

2018-10-12 Thread Toni Förster
Thanks allot. I changed the the line for the linker flags. > From my understanding your change will use GLVND on my system. Wouldn't this > make bug hunting a > bit more complicated, because some bugs may appear on systems using the > legacy GL driver but not > on systems using GLVND libraries?

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmakepolicy_2 into lp:widelands

2018-10-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 4113. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/440355897. Appveyor build 3910. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepoli

[Widelands-dev] [Build #15531998] i386 build of widelands 1:19-ppa0-bzr8876-201810120802~ubuntu14.04.1 in ubuntu trusty RELEASE [~widelands-dev/ubuntu/widelands-daily]

2018-10-12 Thread Launchpad Buildd System
* Source Package: widelands * Version: 1:19-ppa0-bzr8876-201810120802~ubuntu14.04.1 * Architecture: i386 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 3 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/ubuntu/wid

[Widelands-dev] [Build #15531997] amd64 build of widelands 1:19-ppa0-bzr8876-201810120802~ubuntu14.04.1 in ubuntu trusty RELEASE [~widelands-dev/ubuntu/widelands-daily]

2018-10-12 Thread Launchpad Buildd System
* Source Package: widelands * Version: 1:19-ppa0-bzr8876-201810120802~ubuntu14.04.1 * Architecture: amd64 * Archive: ~widelands-dev/ubuntu/widelands-daily * Component: main * State: Failed to build * Duration: 5 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/ubuntu/wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmakepolicy into lp:widelands

2018-10-12 Thread kaputtnik
>From my understanding your change will use GLVND on my system. Wouldn't this >make bug hunting a bit more complicated, because some bugs may appear on >systems using the legacy GL driver but not on systems using GLVND libraries? Anyway, i have removed the linker flags bit by bit (from right to