Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands

2018-10-24 Thread GunChleoc
Review: Resubmit Save game screen should be fixed now -- https://code.launchpad.net/~widelands-dev/widelands/bug-1798812-replay-savegame-type/+merge/357588 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798024-heap-use-after-free into lp:widelands

2018-10-24 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1798024-heap-use-after-free into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1798024-heap-use-after-free/+merge/356825 -- Your team

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-24 Thread GunChleoc
I don't see any diff here. Did you push your changes? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798024-heap-use-after-free into lp:widelands

2018-10-24 Thread GunChleoc
Thanks for the review! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1798024-heap-use-after-free/+merge/356825 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1798024-heap-use-after-free.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands

2018-10-24 Thread GunChleoc
1. Replays don't know if the came from a single or multiplayer game, so we can't filter for that here. 2. Good point, needs fixing -- https://code.launchpad.net/~widelands-dev/widelands/bug-1798812-replay-savegame-type/+merge/357588 Your team Widelands Developers is requested to review the