The proposal to merge lp:~widelands-dev/widelands/ai-military-changes into
lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai-military-changes/+merge/253881
--
Your team Widelands Developers
Review: Approve
:) let make an agreement: If there will be another requests to change
something I will change also this, can be?
Pf. I changed ts_type to trainingsite_type - I took the time, it took me 36
seconds. Should not have taken you much longer than typing this comment.
I think
I changed ts_type to trainingsite_type - I took the time, it took me 36
seconds.
ts_type is definitely safe string to use sed (or other tool) to replace all
occurrences, but to use sed to replace strings 'basic' and 'advanced' - it
would be quite different
--
Just imagine that you get hit by a bus tomorrow and that in 10 year's time
another developer is trying to understand your code. So yes, just a handful of
developers is important, which is why I posted my idea of how they might be
named ;)
--
:) let make an agreement: If there will be another requests to change something
I will change also this, can be?
--
https://code.launchpad.net/~widelands-dev/widelands/ai-military-changes/+merge/253881
Your team Widelands Developers is subscribed to branch
Review: Needs Fixing
Please change the AI hint from ts_type=2 to something that is more
understandable outside of the AI context, maybe
trainingssite_type=no_bread_just_meat or something along these lines. Numbers
are fully opaque to everybody that looks at the conf files.
Diff comments:
@GunChleoc - you undestand that this will be completely hidden form everybody
except handful of developers who will ever look at code. And perhaps few other
peoples who will tinker with config files...
I already reworked this so I am not eager much to rework this once more, but if
you really
re type of trainingsites: type 1 needs less resources (to build and to operate)
and type 2 needs more (including gold, weapons), so type 1 can and should be
built sooner. But I can rename this classification to basic and advanced,
though this is not ideal neither.
--
, this time only files within src/ai/ were changed.
Reworked were:
- attacking
- training sites
- mines
- further small things
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai-military-changes into lp:widelands.
=== modified file 'src/ai
9 matches
Mail list logo
