Review: Approve
I refactored the enums, made the status function return strings, and added some
tests. Please review my code before merging.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/bug-1380287 into lp:widelands
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
--
Your team Widelands Developers is subscribed to branch
lp
reworked to use the strings
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands
/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
the code if the C++
enum should change.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands
merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https
broke if somebody
changed the enum somewhere... But I could do this, allright... I will consider
it
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug
types,
in case you want to steal some code.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands
is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1380287 into lp:widelands.
=== modified file 'src/logic/ship.cc'
--- src/logic/ship.cc 2015-02-05 12:11:20 +
+++ src/logic/ship.cc 2015-03-10 20:18:11 +
@@ -831,6 +831,22 @@
m_expedition-island_exploration = false
9 matches
Mail list logo