Seems some pre installation scripts failed (downloading InnoSetup) on Appveyor.
I've triggered a re-build of this commit:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_scripting-686
--
https://code.launchpad.net/~widelands-dev/widelands/bug-139
Review: Approve
LGTM
I see appveyor reports failed...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/288975
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395278-scripting.
___
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-scripting into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/288975
--
Your team Widelands Developers is subs
Thanks for the review :)
AppVeyor fails a lot on the downloads - the service is quite new, and I guess
they're still working out the kinks.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/288975
Your team Widelands Developers is subscribed to
Continuous integration builds have changed state:
Travis build 842. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/116056744.
Appveyor build 686. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_
Continuous integration builds have changed state:
Travis build 842. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/116056744.
Appveyor build 676. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_s
Continuous integration builds have changed state:
Travis build 673. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/108855068.
Appveyor build 525. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-scripting into
lp:widelands has been updated.
Commit Message changed to:
Refactored member function names in src/scripting.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/28897
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1395278-scripting into lp:widelands.
Commit message:
Refactored member variable and function names in src/scripting.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate na
The proposal to merge lp:~widelands-dev/widelands/bug-1395278-scripting into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
--
Your team Widelands Developers is subs
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395278-scripting.
___
Mailing list: https://launchpad.n
SirVer is out master of everything, but I have worked a bit on Lua and
saveloading as well, so I think this change should be fine. I have opened a new
bug.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
Your team Widelands Developers i
Continuous integration builds have changed state:
Travis build 673. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/108855068.
Appveyor build 525. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1395278_
Hello GunChleoc, I cared for the copyright.
For the type of the player_num / player_index we shoud use the type you
suggested, of course.
But this is
a) out of scope of the original bug.
b) I have no Idea what, especially in LUA, might break.-
We should delegate this to some other ticket.
BTW:
Code LGTM, but I have added some comments. Please have a look :)
Diff comments:
>
> === modified file 'src/scripting/lua_game.cc'
> --- src/scripting/lua_game.cc 2016-01-28 05:24:34 +
> +++ src/scripting/lua_game.cc 2016-02-12 17:03:35 +
> @@ -1132,19 +1132,19 @@
> };
>
> LuaMessage
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-scripting into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
* Switch from m_ to _
16 matches
Mail list logo
