*happy* Thanks for testing, everyone!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
--
Your team Widelands Developers is subscribed to bra
Review: Approve
Nice, thanks Gun.
I can compile fine and do not find those bugs active any longer.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
Review: Resubmit
I have decided to only filter out the characters that can lead to potential
crashes, not the "inconvenient" ones that look confusing on the command line
(like e.g. $).
I have tested on Windows and all should be fine now - both bugs fixed.
--
Review: Approve compile, review, test
OK, Tested some "evil" charaters. On OSX '`ยด&$()[]{} are allowed while |/":*
are not (incomplete).
Maybe we should filter these as well, to avoid Filenames with bad effects on
the Commandline?
OTOH the average user will not not use such characters, will
Continuous integration builds have changed state:
Travis build 1236. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/149854580.
Appveyor build 1078. State: success. Details:
Testing on OSX:
* removed .widelands folder
* :bug-1588063$ ./widelands --editor
* Created some random map and saved it
* found ./widelands/maps/My_Maps, OK
* Copied some selfmade map into ./widelands/maps
ls -R maps
Crossriver.wmf My_Maps
maps/My_Maps:
Test1608558.wmf
* I can open
Continuous integration builds have changed state:
Travis build 1231. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/149798427.
Appveyor build 1073. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
The read operation timed out
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
Continuous integration builds have changed state:
Travis build 1229. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/149710458.
Appveyor build 1071. State: failed. Details:
The proposal to merge lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
has been updated.
Commit Message changed to:
Fix automatic creation of the maps/My_Maps folder in Windows. Prevent the user
from entering illegal filenames.
For more details, see:
https://code.launchpad.net
Continuous integration builds have changed state:
Travis build 1222. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/148893466.
Appveyor build 1064. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
___
Continuous integration builds have changed state:
Travis build 1222. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/148893466.
Appveyor build 1064. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
The read operation timed out
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1588063.
Continuous integration builds have changed state:
Travis build 1222. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/148893466.
Appveyor build 1064. State: success. Details:
Continuous integration builds have changed state:
Travis build 1222. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/148893466.
Appveyor build 1064. State: success. Details:
Review: Needs Fixing
Found another bug in the current state of implementation:
https://bugs.launchpad.net/widelands/+bug/1608558
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is subscribed to branch
Ah, bl*** file separators, my bad.
I will look into concatenating this properly.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1588063/+merge/301636
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1588063 into lp:widelands
because i lack c++ knowledge to concatenate
char/char*/char[].
Suggestions welcome.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1588063 into lp:widelands.
=== modified file 'src/editor/ui_menus/main_menu_save_map.cc'
---
20 matches
Mail list logo
