The proposal to merge lp:~widelands-dev/widelands/bug-1734046-statistics_menu
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
--
Your team Widela
MacOX can't install sphinx
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1734046-statistics_menu/+merge/334398
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1734046-statistics_menu.
Well, in this case, it seems like I can't, except for the one in the
interactive base - I'll get a heap-use-after-free because boost:signals2 will
barf on it - it just doesn't like it when the window containing the button is
gone, just like with the original bug.
Lambdas are nice though, they
Review: Approve
two nits - always prefer lambdas over bind if you can.
Diff comments:
>
> === modified file 'src/wui/game_options_menu.cc'
> --- src/wui/game_options_menu.cc 2017-02-21 07:56:18 +
> +++ src/wui/game_options_menu.cc 2017-11-29 05:07:40 +
> @@ -114,14 +114,17 @@
4 matches
Mail list logo
