The proposal to merge
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
--
Your t
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable.
___
Mailing
Continuous integration builds have changed state:
Travis build 3971. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/428541931.
Appveyor build 3769. State: success. Details:
Continuous integration builds have changed state:
Travis build 3960. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/428009824.
Appveyor build 3758. State: failed. Details:
Continuous integration builds have changed state:
Travis build 3949. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/427562201.
Appveyor build 3747. State: failed. Details:
That's a missing include.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable.
Continuous integration builds have changed state:
Travis build 3940. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/427333771.
Appveyor build 3738. State: failed. Details:
appveyor failed on a reason different to the issue with glbinding.
something with throw Wexcepetion which I don't understand
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 3933. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/427067915.
Appveyor build 3731. State: failed. Details:
this will fail in CI, as it does not contain any of the late fixes for them
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is subscribed to branch
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 3887. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/424046125.
--
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable.
Review: Approve code
Code LGTM. Nice catch :)
The problem was that the WorkerDescr fetched the table, then took only value
[1], then discarded the table, so [2] was unused. Then it fetched the table
anew, used only key [2], and discarded the table, so value [1] was unused. A
table always
-in-luatable/+merge/354202
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into
lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
/_widelands_dev_widelands_bug_1772168_unused_key_in_luatable-3685.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1772168-unused-key-in-luatable/+merge/354202
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into
lp:widelands
idelands/bug-1772168-unused-key-in-luatable/+merge/354202
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into
lp:widelands.
=== modified file 'src/graphic/animation.cc'
--- src/graphic/animation.cc 2018-07-0
16 matches
Mail list logo
