[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20

2019-04-23 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20 has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1825925-mac-dylib-fix/+merge/366418 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20

2019-04-23 Thread Toni Förster
It is indeed :). Let's go with your solution. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1825925-mac-dylib-fix/+merge/366418 Your team Widelands Developers is subscribed to branch lp:widelands/build20. ___ Mailing list: https://launchpad

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20

2019-04-23 Thread SirVer
It's kinda fun that we both solved the same problem at the same time, isn't it? :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1825925-mac-dylib-fix/+merge/366418 Your team Widelands Developers is subscribed to branch lp:widelands/build20.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20

2019-04-23 Thread SirVer
I do feel that this might do the wrong thing for the executable itself (i.e. the widelands binary), since it also changes the id of it. Not sure what behavior this has. The code is also still containing the bug that the id line is parsed as if it where a dependency. Since I was not sure if the

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20

2019-04-23 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1825925-mac-dylib-fix into lp:widelands/build20. Commit message: macOS: fix ids for dylib Requested reviews: SirVer (sirver) Related bugs: Bug #1825925 in widelands: "Mac OS builds for >= 10.9 have no sound playing" https://