Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-31 Thread cghislai
I just resolved them -- https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1205010. ___ Mailing list: https://launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-31 Thread SirVer
Review: Approve Thanks. I changed some nits and merged. Please let me know when you are not happy about the changes I did and I can revert them in trunk. -- https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137 Your team Widelands Developers is subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-31 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug1205010 into lp:widelands has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137 -- https://code.launchpad.net/~widelands-dev/widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-27 Thread SirVer
Just a general though that crossed my mind: we have many 'manual' test cases in the last few days (like the one you describe in your last sentence). How about starting a test suite with lua scenarios that can be automatically run (like ts.wmf)? they would set up a starting condition (a bunch of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-27 Thread SirVer
Review: Needs Fixing -- https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1205010. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-27 Thread cghislai
Indeed a proper test suite would be nice. and each bug fixed should have, if possible, a test written to check for regression. But as you said some handler function would be required. I may try to implement that, but Im don't think that should be ready for b18. Maybe we could open a blueprint

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-27 Thread SirVer
Indeed a proper test suite would be nice. and each bug fixed should have, if possible, a test written to check for regression. But as you said some handler function would be required. I think starting out with a directory of .wmf files and run each in order from a shell script (i.e. always

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1205010 into lp:widelands

2013-07-26 Thread cghislai
or another one. In the former case, in case of enhanced building, the correct amount of ware was computed for dismantling. -- https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev