I've created a wikipage and a blueprint for further discussion of the
IRCBridge: https://wl.widelands.org/wiki/IrcBridgeImprovements/
Please add comments, request and suggestions. I will try to improve the
handling of the bridge on both client and server side.
--
Review: Approve
Is the IRC bridge now frozen or is it still evolving?
That depends. Tino wrote it and I have no idea if he has plans on continue
working on it. I am too loaded to improve it tough I find the project very
intriguing. It is not feature complete as there is no design doc for it.
The proposal to merge lp:~widelands-dev/widelands/feature-loudylobby into
lp:widelands has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/feature-loudylobby/+merge/213784
--
https://code.launchpad.net/~widelands-dev
:
- Very simple change. Improves the use experience in my opinion.
Bad:
- Hard-coded string constants are ugly.
--
https://code.launchpad.net/~widelands-dev/widelands/feature-loudylobby/+merge/213784
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
hosting to be implemented.
--
https://code.launchpad.net/~widelands-dev/widelands/feature-loudylobby/+merge/213784
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/feature-loudylobby into lp:widelands
Review: Approve
Approved not just because the code looks good, but as well because it simply
works and because I was wishing for such a feature for some time already :)
--
https://code.launchpad.net/~widelands-dev/widelands/feature-loudylobby/+merge/207819
Your team Widelands Developers is
Review: Needs Fixing
Just a nit: Please change:
if (not msgs . back() . sender . empty())
116 + // Alert me!
117 + play_new_chat_message();
to
if (!msgs.back().sender.empty()) {
// Alert me!
play_new_chat_message();
}
and I do not
/~widelands-dev/widelands/feature-loudylobby/+merge/207819
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/feature-loudylobby into lp:widelands.
=== added file 'sound/message_chat_00.ogg'
Binary files sound/message_chat_00.ogg 1970-01-01 00:00:00
8 matches
Mail list logo
