The proposal to merge lp:~widelands-dev/widelands/fix_world_names into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
--
https://code.launchpad.net/~widelands-dev/widela
OK, new branch:
https://code.launchpad.net/~widelands-dev/widelands/skeletons2seashells
Let's scrap this one.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_world_names.
No, changing the descname is fine and can be done without issues. I think this
is preferable to Teppos suggestion actually.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_
I had another idea: what will heppen if I change just the localization string,
e.g.
name = "skeleton4",
descname = _ "Seashell",
Will that cause problems?
--
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Your team Widelands Developers is subscribed to branch
If it's creating a problem, leave it - it is not that important.
I will add translator comments instead, so translators will know that it's a
seashell if they're paying attention.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Your team Widelands Developers
> another layer of compatibility code, which I'd rather avoid.
Could this be in one of those cases where polishing the English should be done
at Widelands-to British/American/whatever translations instead of the Widelands
code itself?
--
https://code.launchpad.net/~widelands-dev/widelands/fix
Review: Needs Fixing
Do you really want to do this? I ask because I think that seashells are a kind
of skeleton :P.
Also, the implications here are that all maps created between the one world
merge and this will be unloadable (and there have been at least 2 linked in the
forums already) withou
GunChleoc has proposed merging lp:~widelands-dev/widelands/fix_world_names into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Some of the skeletons are actually sea
8 matches
Mail list logo
