Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-10 Thread GunChleoc
> SirVer: we need a command "fail" in the debugconsole, to trigger an assert that will kind of kill such a game. Can you open a bug report and give more details on what we need? Once a merge request is merged, chances are small that SirVer will look at the comments a all ;) --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-09 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/internet-gaming-reset/+merge/337129 -- Your team Widelands Develop

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-09 Thread Klaus Halfmann
Review: Approve testplay Did some more "real" testing with Notablis, all as stable as it can be. SirVer: we need a command "fail" in the debugconsole, to trigger an assert that will kind of kill such a game. Meanwhile we had kind of fun with switchplayer :-) @bunnybot merge --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-09 Thread Klaus Halfmann
OK, I should have a bit of time today, lets try around 17:00 CET. Well if they loby is useless in such a situation we should either: * try to reconnect in the lobby and show the user some response. * completey drop out to the main menu. With the first option we may loose some lobby messages,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-08 Thread Notabilis
Thanks for testing. A test game does not make sense for this branch. But if you want to do one anyway, I have time this evening. What do you mean with "coming back into the lobby"? Have you been in the main menu and clicked on Internet Gaming again? The empty lobby after the disconnect is an

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-08 Thread Klaus Halfmann
Review: Approve Hmm, I pulled the cable during game and got e.g. [sync] Reset InternetGaming: Game update on metaserver. ... InternetGaming: Connecting to the metaserver. Could not resolve network name: resolve: Host not found (authoritative) InternetGaming: Sending login request.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-06 Thread Klaus Halfmann
-dev/widelands/internet-gaming-reset into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-04 Thread bunnybot
/_widelands_dev_widelands_internet_gaming_reset-2944. -- https://code.launchpad.net/~widelands-dev/widelands/internet-gaming-reset/+merge/337129 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands

2018-02-04 Thread Notabilis
is not reset, resulting in a wrong state of the lobby after logging in again. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/internet-gaming-reset into lp:widelands. === modified file 'src/network/internet_gaming.cc' --- src/network