[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-17 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 -- Your team Widelands Develop

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-17 Thread GunChleoc
Let's have it :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread bunnybot
Continuous integration builds have changed state: Travis build 3809. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416493186. Appveyor build 3608. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread Toni Förster
I just added a check for ccache and added gettext to $PATH to avoid force linking it (removed thsi line from the wiki). Also merged from trunk. ASan stays disabled for GCC since it does not pass the test and throws error like this one: Start 1: test_economy 1/4 Test #1: test_economy

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread Klaus Halfmann
Review: Approve dowload,short testrun Approve, checked both images, (debug build is 50M, my develop build is 67M but all libs are staically linked) I only tried to open a savegame. (which was from some other brach, and failed to load, well) travis currebtly has some erro as of a broken test

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread Klaus Halfmann
@Toni We already have a description to build developer verions using macports: https://wl.widelands.org/wiki/Download/ And some dsicussion around this as well: https://wl.widelands.org/forum/topic/2627/ And the corresponding Portfile, which includes some packagnh, too:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 -- Your team Widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread Toni Förster
@Klaus is there something like "brew --prefix" for MacPorts? We could easily adapt the script to handle both package manager. Also ASsam is enabled by default for debug builds in the "CMakeLists.txt" That's why I havn't had to enable it for debug. I disabled it for GCC, though. --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-15 Thread bunnybot
Continuous integration builds have changed state: Travis build 3805. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416197711. Appveyor build 3604. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread GunChleoc
> SirVer, Gun: do we have that Ticket still in some Archive? There is nothing relevant with the "macos" tag in the archive. Of course, such a bug might have been fix released before I did the tag cleanup. --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3800. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/416061570. Appveyor build 3599. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Toni Förster
Here are the clang builds: http://fosuta.org/widelands_64bit_r8786.dmg http://fosuta.org/widelands_64bit_r8786_Debug.dmg -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
I rember that SirVer used brew as well for R19 and I used macports and we had some significat differences in the end, was much bigger, or such. SirVer, Gun: do we have that Ticket still in some Archive? Once we target R20 we should use all variants and use the smalles/fastest on. Lets see. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Toni Förster
$ ./build_app.sh clang debug ../macos_build_app_compiler gives me this output later on -- Using AddressSanitizer http://clang.llvm.org/docs/AddressSanitizer.html So it is using it without explicitly declaring it. Does work with clang. gcc currently gives me headaches, though. It seems to use

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
Mmh, this does not contain the ASAN Flags as we have them in compile.sh, this would make sense for a debug build (yes, it _is_ slower :-) OTOH wee need this just for the release in then End, I would guess. I use macports so lets try this now wlbuild klaus$ ./build_app.sh clang debug

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
Toni, you re doing a great job! Just give me some time to catch up with your speed :-) You may contact me via PM or such, so we can align on our skills. Ill try to review this this week but will not promise anything ... --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3796. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415851588. Appveyor build 3595. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread GunChleoc
Review: Approve Code LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-13 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Description changed to: One can choose between Clang and GCC now. The Wiki has been changed accordingly: https://wl.widelands.org/wiki/Building_Widelands_on_macOS/ For more details

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-13 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Description changed to: One can choose between Clang and GCC now. The Wiki has been changed accordingly: https://wl.widelands.org/wiki/Building Widelands on macOS/ For more details

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-13 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Description changed to: One can choose between Clang and GCC now. The Wiki has been changed accordingly: https://wl.widelands.org/wiki/BuildingWidelandsonmacOS/ For more details, see

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-13 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands has been updated. Commit message changed to: choose between compiler clang or gcc, specify build type: debug or release For more details, see: https://code.launchpad.net/~widelands-dev/widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-13 Thread Toni Förster
the proposed merge of lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands. === modified file 'utils/macos/build_app.sh' --- utils/macos/build_app.sh 2018-08-13 21:53:55 + +++ utils/macos/build_app.sh 2018-08-13 21:53:56 + @@ -2,9 +2,9 @@ set -e -if [ "$#" == "0&