Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-09-01 Thread GunChleoc
I can reproduce the problem now in an Ubuntu trusty VM. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/list-directories-in-cpp.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-08-26 Thread GunChleoc
No, I still need to find the bug that occurs with some compilers. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/list-directories-in-cpp.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-08-25 Thread Toni Förster
Is it okay to force merge this branch? test/maps/expedition.wmf/scripting/test_check_transportation_works_one_ship.lua ... Running Widelands ... Seems to time out in some builds. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your team

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-25 Thread bunnybot
Continuous integration builds have changed state: Travis build 5242. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/549900235. Appveyor build 5021. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-14 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 5191. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/545623652. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-13 Thread Notabilis
Review: Approve Looking good now, thanks. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/list-directories-in-cpp. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-08 Thread GunChleoc
} else { > - throw UnhandledVersionError( > - "ActConstructData", packet_version, > kCurrentPacketVersionConstructionData); > - } > - } catch (const WException& e) { >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-08 Thread Notabilis
} > - } catch (const WException& e) { > - delete d; > - d = nullptr; > - throw GameDataError("ActConstructData: %s", e.what()); > - } > - > - return d; &g

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-05-26 Thread bunnybot
/_widelands_dev_widelands_unify_program_parsers-4841. -- https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-05-26 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands has been updated. Commit message changed to: Refactor program parsers - Pull out common code into new class MapObjectProgram - Fix ware demand checks so that they only affect the correct tribes - Get rid