The proposal to merge lp:~widelands-dev/widelands/watchwindow-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
--
Your team Widelands Developers is subscri
Cool, thanks for testing and fixing! Travis went through as well.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
Review: Approve test / compile
Bug #1553699? is fixed with this branch,
just reproduced this on bzr7903[trunk],
and found it fixed it here in bzr7904[watchwindow-fixes]
@Miroslav Remák: thanks for fixing this.
--
@Klaus Halfmann
Also, did you notice the reproduction steps I posted in bug #1553699? Can you
try these steps with the version used in the bug report (bzr7866) to see if
they produce a crash and if so, try the same steps with this branch?
--
> I am still missing some comments about the basic
> workings of this (very sepcial) window. and I have some questions:
>
> * why is uint8_t as index, a plain unsigned int would not make a difference?
Old code. We actually think that using int is even better than unsigned int,
because it
I am still missing some comments about the basic
workings of this (very sepcial) window. and I have some questions:
* why is uint8_t as index, a plain unsigned int would not make a difference?
* why is there no visual response when adding the last view fails?
I cannot reproduce #1553699
New changes still LGTM - Happy :)
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
___
Mailing list:
Ill try to reproduce #1553699 whit this perhaps today ...
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
___
Review: Approve
LGTM :)
I think it would also be great when a new location is added, that the window
activates that new location. It doesn't do that in trunk either though, so it's
up to you if you want to work on this in this branch.
--
is requested to review the proposed merge of
lp:~widelands-dev/widelands/watchwindow-fixes into lp:widelands.
=== modified file 'src/wui/watchwindow.cc'
--- src/wui/watchwindow.cc 2016-02-18 18:27:52 +
+++ src/wui/watchwindow.cc 2016-03-19 23:00:17 +
@@ -62,8 +62,8 @@
boost::signals2::signal
10 matches
Mail list logo
