Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-12 Thread Benedikt Straub
If I may be so bold – I have added the missing dev-credit entry for myself here, and as there are two approves: @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-11 Thread Benedikt Straub
@Klaus: I don´t think using real portraits would work. There are very few portraits of Frisians. Aldgisl is about as close as we can get, and he was a Western Frisian duke (so he´d fit to Reebaud, who seems more Western than Northern frisian anyway), but there are few others. In the middle

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-10 Thread hessenfarmer
Review: Approve At least the style is consistent now. I think the difference to the frisians is good for the player to distinguish between them easily. Thanks a lot -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-10 Thread Benedikt Straub
Portrait for Murilius is uploaded. He looks a bit different to the Frisian people though ;) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-10 Thread Benedikt Straub
Yes, the empire workers are also in the repo. It´ll still look somewhat different though due to different modelling style. I´ll make the image this evening :) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-10 Thread hessenfarmer
the portraits are better now with the canvas texture they don't look that bad anymore. Do you have the blender files for the romans as well to create a Screenshot also for Murilius? That would give us some consistency over the Frisian campaign --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-10 Thread Benedikt Straub
I have given the portraits (including Murilius) some editing in GIMP now to give them a painting-like look and a playercolored frame. How about these? -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-08 Thread hessenfarmer
I think the new pictures do not fit in the context of the other Scenarios where portraits are used. This will especially evident in the 2nd Frisian scenario so my personal taste would be to keep the false portraits as they are currently rather than having these screenshots. If the new pictures

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-08 Thread hessenfarmer
Furthermore they could be enriched with the playercolor in the scenario. (e.g. blue for Hauke and Rebaud) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-06 Thread Klaus Halfmann
Review: Approve OK, the portraits work as designed. But as we already have a real Islnad could we have some +/- real Perons portrait, too? Like https://de.wikipedia.org/wiki/Aldgisl Or from here: https://www.youtube.com/watch?v=cVZjSD6_WIQ Or from some local Museum? Fell free to merge,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands

2018-10-06 Thread Klaus Halfmann
Looks like my youtube video reminded you of something ;-) Will check this now. -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fri-portraits into