Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-11-14 Thread GunChleoc
Yes, that's on purpose. We need new art. https://wl.widelands.org/forum/topic/2648/ Thanks for the review @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/scrollbar_beautification/+merge/309635 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-11-14 Thread SirVer
Review: Approve lgtm. Unrelated: have you started the game at 800x600 lately? The 'Widelands' logo is partly covered by the edge images. Diff comments: > > === modified file 'src/ui_basic/table.cc' > --- src/ui_basic/table.cc 2016-10-24 14:04:00 + > +++ src/ui_basic/table.cc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-10-30 Thread Tino
Review: Approve Everything's ok on my end. -- https://code.launchpad.net/~widelands-dev/widelands/scrollbar_beautification/+merge/309635 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/scrollbar_beautification. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_beautification into lp:widelands

2016-10-30 Thread Klaus Halfmann
Review: Needs Fixing compile Mhh, this does not compile for me: In file included from ...widelands-repo/scrollbar_beautification/src/wui/encyclopedia_window.h:32: ...widelands-repo/scrollbar_beautification/src/ui_basic/table.h:352:7: error: no matching constructor for initialization of