[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_062017_windows into lp:widelands

2017-06-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 2384. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/247419025. Appveyor build 2212. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands

2017-06-27 Thread TiborB
OK, next try please Just 2 points - diff here on web page is truncated - there is still one NOCOM and response to Gun in that cut off part of the diff... -- https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796 Your team Widelands Developers is requested to review the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread kaputtnik
Thanks for implementing this. I think this is a great enhancement to the UI :-) -- https://code.launchpad.net/~widelands-dev/widelands/multiplayer_dropdowns/+merge/326302 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/multiplayer_dropdowns_2_init_team.

[Widelands-dev] [Merge] lp:~hjd/widelands/boost-dependencies into lp:widelands

2017-06-27 Thread Hans Joachim Desserud
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/boost-dependencies into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1697192 in widelands: "Cleanup after move to boost.net" https://bugs.launchpad.net/widelands/+bug/1697192 For more

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread kaputtnik
I found what causing this: Please try to click on the top area of a drop down button, so the tooltip is very near (or overlaps) the button. Then the drop down box disappear after mouse release. If i click in the bottom area, all works fine. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread GunChleoc
Now I get what you mean. Dropdowns will autoclose when you move the mouse away, and the tolerance on the top edge was too small. Should be fixed now. -- https://code.launchpad.net/~widelands-dev/widelands/multiplayer_dropdowns/+merge/326302 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread kaputtnik
Review: Approve testing Yes, it's working now :-) I am not familiar with the mutliplayer things, so i guess it's ok that the mutliplayer scenarios shows "Suggested teams" but one could not setup a team (e.g. Smugglers). Nevertheless disturbing. This applies also to the map "Trident of fire"

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread GunChleoc
Great that it was an easy fix for once :) Regarding the suggested teams, that's a feature that I've had in my head for years now. Once we have finished overhauling all the screens, I will get to work. Also, once the overhaul is finished, I will make some options for the win conditions

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread GunChleoc
I have now tried this with setting up games between my Linux and Windows machines using the AppVeyor build, and I get none of these problems. Not a single one, all dropdowns work perfectly. So, I have no clue how I could possibly debug this :( --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands

2017-06-27 Thread TiborB
OK, we will leave the command line switch for the next time. I will go over the code again and let you know when it will be ready -- https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796 Your team Widelands Developers is requested to review the proposed merge of

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/multiplayer_dropdowns into lp:widelands

2017-06-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 2381. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/247251733. Appveyor build 2209. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands

2017-06-27 Thread GunChleoc
I ave been thinking about the command line parameter, we should do that in a follow-up branch and just set kAITrainingMode to false for now. This will make it easier to review. You can also use kAITrainingMode in the interactive base for switching the game speed code on and off, this way that

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-internetgaming-ipv6 into lp:widelands

2017-06-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 2383. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/247296957. Appveyor build 2211. State: success. Details: