Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread hessenfarmer
UI stats are calcualted over the last 20 real attempts. Skipped does not count as attempt. It is build like a shifting register with 20 positions containing true or false. it is falling faster for most buildings due to the fail time is shorter than working time. if fail time is really short it

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread TiborB
I see the opinions differ too much. I see these options: - no change - this change - no change, but expose official statistics to the AI's genetic algorithm and retrain - this change, but expose official statistics to the AI's genetic algorithm and retrain - remove this crude_statistics, and

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread TiborB
I completely understand current code. If it was "attempts in last x minutes" - it would be fine for me. But 'last 20 attempts' - this I understand from coding perspective - but dont like it. 'official statistics' to me is like actual_statistics^2. 100% and 0% are right, but in between it is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread hessenfarmer
Hm I made a excel now. reported a bug to upload it and linked it to this branch. It seems your formula is delivering weird results. I don't know why or if I made a mistake. I think I don't have understood this in total but at least the old crude_statistics wasn't that far from UI but more

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread hessenfarmer
Review: Approve Got the concept. I think we should have this after you perhaps might fix the small nits from the below diff comments Diff comments: > === modified file 'src/logic/map_objects/tribes/productionsite.cc' > --- src/logic/map_objects/tribes/productionsite.cc2019-05-18 11:58:43

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands

2019-05-21 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands. Commit message: Some AI training Requested reviews: Widelands Developers (widelands-dev) For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread TiborB
OK, comments implemented. -- https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_productionsites_statistics. ___ Mailing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread hessenfarmer
by the way I now see another option. - this change plus exposing the new crude Statistics to the UI ;-) -- https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread TiborB
Low utilization can mean one of two shortage of inputs or that the output is not needed. So by my opinion, skipped programs should be included in statistics... Because utilization close to 100 while the building being idle most of time can confuse players in believing that new building is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands

2019-05-21 Thread TiborB
But at least somebody should formally approve this :) -- https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_21052019/+merge/367709 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread hessenfarmer
ok you are right especially for the AI cause the AI might want to build another idle building then. However we should perhaps have different rating for failed and skipped. If you like we could deliver only half of the duration time to the update fuctionality in case we skipped so it will fall

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands

2019-05-21 Thread TiborB
For AI this is the best I believe... -- https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_productionsites_statistics.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands

2019-05-21 Thread hessenfarmer
Review: Approve I have tested them. results look good. also the values with the new logics unmasked the need for some more basic buildings. bug is created. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_21052019/+merge/367709 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands

2019-05-21 Thread bunnybot
Continuous integration builds have changed state: Travis build 5024. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/535462118. Appveyor build 4804. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands

2019-05-21 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_new_wai_files_21052019 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_21052019/+merge/367709 -- Your team Widelands