[Widelands-dev] [Merge] lp:~widelands-dev/widelands/congestion2 into lp:widelands
Continuous integration builds have changed state: Travis build 3727. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/408616293. Appveyor build 3527. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_congestion2-3527. -- https://code.launchpad.net/~widelands-dev/widelands/congestion2/+merge/348525 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/congestion2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rip_out_old_fontrenderer into lp:widelands
Review: Approve testing Tested, found no issues :-) -- https://code.launchpad.net/~widelands-dev/widelands/rip_out_old_fontrenderer/+merge/350442 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rip_out_old_fontrenderer. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands
Continuous integration builds have changed state: Travis build 3726. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/408470458. Appveyor build 3526. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_no_hardcoded_resources-3526. -- https://code.launchpad.net/~widelands-dev/widelands/no-hardcoded-resources/+merge/350750 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
Review: Needs Fixing After discussing this in the Forum the marble mine probability settings need to be changed back to 20%. found another issue in the code of the mine program in lines following https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/map_objects/tribes/production_program.cc#L1164 a penalty for depleting fields is defined. this leads to a failed production program without taking into account the chance when depleted. see line https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/map_objects/tribes/production_program.cc#L1214 so the situation where 2 mined resources could be thrown away (3rd mining step failing seem to be much more frequent than I thought. This effect will be worse the bigger the radius is (worst for Atlanteans) So we need to consider this in the programs probably or we need to change the mining code -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
Review: Approve review Found no more errors, changes look sensible. Didn´t test. -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
