[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786163 into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1786163 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1786163/+merge/352947 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786163. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786163 into lp:widelands
Continuous integration builds have changed state: Travis build 3812. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416774822. Appveyor build 3611. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1786163-3611. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786163/+merge/352947 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786163. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
I agree that is somewhat not very streamlined. The difference for the crystalline is that it produces different outputs while normal mindshare producing only one. So the current design doesn't do that much harm but we should keep this consistent. I from my perspective a beginning sleep of 5 seconds for all mines except crystal and marble mine would be ok. Rest of the sleep time should be moved before the call commands. -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
The atlantian's crystalmine has the sleep between the conditional "return=skipped" and "consume" while all other mines(for all tribes) have it before the return=skipped. Which one is correct? Also I remember that this penalty was removed e.g. for the taverns. Why is it still in place for all the mines except this one? -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
In principle Yes. Needs some reviews however and I can't do this for my own stuff. -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786163 into lp:widelands
Tested. Thanks for the fix! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786163/+merge/352947 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786163. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1787105_tada_edited_sounds into lp:widelands
Continuous integration builds have changed state: Travis build 3811. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416688110. Appveyor build 3610. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1787105_tada_edited_sounds-3610. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1787105_tada_edited_sounds/+merge/353216 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1787105_tada_edited_sounds into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
Is this ready for merging? -- https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1787105_tada_edited_sounds into lp:widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1787105_tada_edited_sounds into lp:widelands. Commit message: Improvements to sounds and the sound mix Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1787105 in widelands: "some edited sounds" https://bugs.launchpad.net/widelands/+bug/1787105 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1787105_tada_edited_sounds/+merge/353216 Not read yet - just for the AppVeyor builds -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1787105_tada_edited_sounds into lp:widelands. === modified file 'data/sound/farm/sheep_01.ogg' Binary files data/sound/farm/sheep_01.ogg 2016-06-09 07:03:20 + and data/sound/farm/sheep_01.ogg 2018-08-16 06:47:00 + differ === modified file 'data/sound/farm/sheep_02.ogg' Binary files data/sound/farm/sheep_02.ogg 2016-06-09 07:03:20 + and data/sound/farm/sheep_02.ogg 2018-08-16 06:47:00 + differ === modified file 'data/sound/farm/sheep_03.ogg' Binary files data/sound/farm/sheep_03.ogg 2016-06-09 07:03:20 + and data/sound/farm/sheep_03.ogg 2018-08-16 06:47:00 + differ ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
