Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/cleanup_playercommand_enums/+merge/369267
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/cleanup_playercommand_enums.
___
Mailing list:
Is it okay to force merge this branch?
test/maps/expedition.wmf/scripting/test_check_transportation_works_one_ship.lua
...
Running Widelands ...
Seems to time out in some builds.
--
https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936
Your team
Stupid me. :-) I installed clamdscan.
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
How do you intend to access clamav? The current mode is via socket:
LocalSocket /var/run/clamav/clamd.ctl
If you'd like, I can add a local TCP daemon on port 3310.
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands Developers is
Already installed. ;)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
Review: Approve
LGTM :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/update_ops_script/+merge/369163
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Diff comments:
> === modified file '_ops/apt_update.sh'
> --- _ops/apt_update.sh2016-08-26 10:55:57 +
> +++ _ops/apt_update.sh2019-06-21 11:41:04 +
> @@ -1,28 +1,25 @@
> #!/bin/sh
> # Updates all packages on the server, but stops the widelands website before
> #
Fixed it. You just need:
sudo systemctl stop wl-website
at the beginning and
sudo systemctl start wl-website
ath the and.
I left the wl-bauarbeiten.service in place but it is not necessary to call it
anymore. When stopping the wl-website service it will automatically enable the
bauarbeiten
Review: Needs Fixing
Diff comments:
> === modified file '_ops/apt_update.sh'
> --- _ops/apt_update.sh2016-08-26 10:55:57 +
> +++ _ops/apt_update.sh2019-06-21 11:41:04 +
> @@ -1,28 +1,25 @@
> #!/bin/sh
> # Updates all packages on the server, but stops the widelands
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1833352-empty-game-names/+merge/369094
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1833352-empty-game-names.
___
Mailing list:
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1833352-empty-game-names into lp:widelands.
Commit message:
Fix for corner case: don't set empty game name if no game is present
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1833352 in widelands
Review: Approve
I'm happy :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1826744-lobby-commands.
But I guess this should be solved on the server side...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1826744-lobby-commands.
Review: Approve
LGTM :)
But we need the server to be in place to test this better.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1826744-lobby-commands.
I meant to add Hessenfarmer...
--
https://code.launchpad.net/~widelands-dev/widelands/atlantean_fishbreeder/+merge/368442
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/atlantean_fishbreeder into lp:widelands.
Toni Förster has proposed merging
lp:~widelands-dev/widelands/atlantean_fishbreeder into lp:widelands.
Commit message:
atlantean fishbreeder split time 50/50 building/worker
Requested reviews:
kaputtnik (franku)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands
Sorry, I was under the impression that users could use the help command as well.
The it is just /announcement command that needs to be changed :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers is requested to review
Could you change "/announcement" to "/announce"? That's the command for the
multiplayer lobby.
Also, could you implement /help for the lobby (for users and superusers)?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers
I added the 2 seconds to the animation.
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
___
Mailing list:
Toni Förster has proposed merging lp:~widelands-dev/widelands/travis_xenial
into lp:widelands.
Commit message:
use xenial on travis
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/travis_xenial/+merge/368237
Changed the timings for woodcutters/forester/quarry they are 50/50 (except
foresters ~60/~40)
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/resize_caret/+merge/368227
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/resize_caret.
___
Mailing list:
Changed the icon for the frisian's ship.
Regarding the bushes, which one in particular do you want to see changed?
--
https://code.launchpad.net/~widelands-dev/widelands/immovables_icon_wrong_path_menu/+merge/368011
Your team Widelands Developers is requested to review the proposed merge of
Toni Förster has proposed merging lp:~widelands-dev/widelands/resize_caret into
lp:widelands.
Commit message:
increased caret to 14px
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/resize_caret/+merge/368227
I'd like to change the woddcutters, (foresters) and quarries as well. They
spend way too much time in their buildings, instead of working. I'd like to
move about 10-15 seconds from the woodcutters & quarries to the worker. And
about 5 for the foresters.
--
Did some changes for fishers and farms. The overall timing is the same as
before. Just the time spend for each step is a little different now.
Frisians are unchanged, that's something I'd like Benedikt to have a look at.
--
Fixed it.
No need to be sorry for RL :-)
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
___
Mailing list:
@hessenfarmer would you be so kind and have a look at the changes I did in the
trainingsites?
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
the inputqueues again
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
___
Mailing
The 10s increase in the test fixed it. But we only need this as long as the
unify_sleep_time isn't merged into branch. We can revert these changes there
because sleeps aren't executed before a possible fail anymore.
@bunnybot merge
--
I just noticed that I forgot the training sites. I started by replacing the
dummy checks with return=no_stats.
I think we should add a return=fail if not enough food/wares are present (like
we have for the aqua farm). To avoid the 30s sleep. Or can we move the sleep
behind that consume part?
This branch fails:
test/maps/plain.wmf/scripting/test_casern.lua
How do I run the test locally?
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
Okay, fixed now :)
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
___
Mailing list:
Added them back in and set the commas.
--
https://code.launchpad.net/~widelands-dev/widelands/unify_sleep_time/+merge/368086
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/unify_sleep_time into
lp:widelands has been updated.
Description changed to:
The basic idea is, we can guarantee that a failed or skipped program will
always be continued after a grace time of 10 seconds.
All calls within a program, may it be
Toni Förster has proposed merging lp:~widelands-dev/widelands/unify_sleep_time
into lp:widelands with lp:~widelands-dev/widelands/failed_skipped_10s as a
prerequisite.
Commit message:
move sleep behind return/consume/callworker
Requested reviews:
hessenfarmer (stephan-lutz)
For more details
Okay, I'm going to set a new branch up that contains the changes to the lua
files. Base will be this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands Developers is subscribed to branch
Will look into this. :)
--
https://code.launchpad.net/~widelands-dev/widelands/immovables_icon_wrong_path_menu/+merge/368011
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/immovables_icon_wrong_path_menu into lp:widelands.
@bunnybot merge :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1830776-password-field-captures-input/+merge/368063
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input.
untangle :D
--
https://code.launchpad.net/~widelands-dev/widelands/immovables_icon_wrong_path_menu/+merge/368011
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/immovables_icon_wrong_path_menu into lp:widelands.
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1830778-lobby-initial-client-layout-broken into
lp:widelands.
Commit message:
lobby set Game column in client list to 3/8 of the width
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1830778
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input into
lp:widelands.
Commit message:
don't force focus on password field
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1830776 in widelands: "Input is cap
Did some thinking :D
> It is not necessary for buildings with leading sleep times of less then 10
> secs as these would been masked by the code now.
> Furthermore it is not necessary for buildings with only one output as the
> effect of wasted time if undersupplied would been averaged over time.
Okay, so basically only the buildings you listed above?
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/failed_skipped_10s.
Changed the icon for the ship and added menu.png for all bushes. The bushes
don't appear in the encyclopedia because nordfriese needs to entangle the lua
files first. Currently, all information including terrain affinity are in one
file.
--
It basically affects all buildings. Most buildings have a sleep before skipped
and/or consume. So we need to move them as well. But the question is, do we
want to move them or add them to the animation cycle? Or at least move some
seconds to the animation cycle?
--
Hmm, there are many more. The question is. Shall we move the sleep time just
behind consume, or remove sleep and add the time to the animation time, were
applicable?
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands Developers is
Found some more. Barbarian's mines. Going to add the changes to this branch,
since it won't be merged because the casern_test failed. I guess we need to
adapt this test as well...
--
https://code.launchpad.net/~widelands-dev/widelands/failed_skipped_10s/+merge/368014
Your team Widelands
should be fixed
--
https://code.launchpad.net/~widelands-dev/widelands/immovables_icon_wrong_path_menu/+merge/368011
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/immovables_icon_wrong_path_menu into lp:widelands.
I used GIMP, already. Where do you get these warnings?
--
https://code.launchpad.net/~widelands-dev/widelands/immovables_icon_wrong_path_menu/+merge/368011
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/immovables_icon_wrong_path_menu into
The proposal to merge lp:~widelands-dev/widelands/failed_skipped_10s into
lp:widelands has been updated.
Commit message changed to:
add failed programs to the skipped stack
don't show % for trend
move sleep behind consume in metal_workshop & toolsmithy
added sound to helmsmithy
For more
Toni Förster has proposed merging
lp:~widelands-dev/widelands/failed_skipped_10s into lp:widelands.
Commit message:
add failed programs to the skipped stack
don't show % for trend
Requested reviews:
hessenfarmer (stephan-lutz)
For more details, see:
https://code.launchpad.net/~widelands
Toni Förster has proposed merging
lp:~widelands-dev/widelands/immovables_icon_wrong_path_menu into lp:widelands.
Commit message:
Fixes wrong path for encyclopedia immovables icon.
Added missing menu icons for immovables.
Requested reviews:
Widelands Developers (widelands-dev)
For more
Review: Approve
LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/list-directories-in-cpp/+merge/366614
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/list-directories-in-cpp.
___
Mailing list:
Since the parent branch has been merged, this can go in as well.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367314
Your team Widelands Developers is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/wrong-password-message/+merge/367929
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/wrong-password-message.
___
Mailing list:
I'd say 2. That would be 20 soldiers right?
--
https://code.launchpad.net/~widelands-dev/widelands/choose-attack-soldiers/+merge/367471
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/choose-attack-soldiers.
___
Review: Approve
LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/tribe-immovable-file-structure/+merge/367611
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/tribe-immovable-file-structure.
___
Mailing
Would it be possible to move the tabs for Warehouses' and Ports' to the top,
instead of having to tab rows?
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your team Widelands Developers is requested to review the proposed merge of
Review: Approve
I think I forgot to approve this :)
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
Also, this needs to be resolved on the Metaserver side.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start.
> Setting a correct password and clicking on 'Save' connects immediately to the
> lobby and immediately disconnect again. One can see this in channel #widelands
> on IRC.
>
That is currently the only way to check whether the password was correct or not.
--
Review: Needs Fixing
The merge conflict needs fixing. Also this is not part of this branch but maybe
can be foxed here.
Game: Reading Map Data ... Game: Reading Map Data took 7ms
Game: Reading Player Info ... ┏━ Running Lua for world:
Here are newlines missing.
Besides that it sped up the
Review: Approve
LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/font_size-lua/+merge/366938
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/font_size-lua.
___
Mailing list:
The proposal to merge
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into
lp:widelands has been updated.
Commit message changed to:
redesigned login box
- renamed to Online game Settings
- limit the possible characters for usernames
- draw a red box around the input
Can you give it another try?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start.
Same savegame with this branch.
Second and third phase loading Map Objects ... took 37ms
Not sure what triggers the underrun on your system. The question is, is this
caused by changes in this branch OR is this a problem with your system that you
never noticed until this branch...
--
The proposal to merge
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into
lp:widelands has been updated.
Commit message changed to:
redesigned login box
- renamed to Online game Settings
- limit the possible characters for usernames
- draw a red box around the input
Seems to be fixed.
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/constructionsite_options into lp:widelands.
r9110 fixed it. Thanks allot.
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
___
Mailing list:
And another assertion.
Assertion failed: (animation_index < animations.size()), function draw, file
/Users/toni/Launchpad/widelands-repo/working_tree/src/logic/map_objects/tribes/constructionsite.cc,
line 85.
--
crash:
NOCOM: EconomyOptionsWindow::update_profiles_select(Default)
Planning to select »Default«
Did not select it because it is already selected
NOCOM: EconomyOptionsWindow::update_profiles, applicable »«
Desired and actual state of the empty »« profile don´t match
NOCOM:
+1
--
https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation/+merge/352844
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/mines-worldsavior.
___
Mailing list: https://launchpad.net/~widelands-dev
I gave it another run. The button is now called “Login settings” and sits in
between the “LAN / Direct IP” ans “Back”.[1] The Title of the Login box has be
renamed accordingly, also the “Login” button has been renamed to “Save”.[2]
The window opens automatically when no username or an invalid
The proposal to merge
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into
lp:widelands has been updated.
Commit message changed to:
redesigned login box
- limit the possible characters for usernames
- draw a red box around the input field for erroneous input
- tell
Hmm, I'm still uncertain. What about this?
https://fosuta.org/pics/multi-settings.png
I have to flesh out the details, though. Bu would this Screen look okay?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands
Assertion failed: (military_site_->capacity_ != capacity), function
set_soldier_capacity, file
/Users/toni/Launchpad/widelands-repo/working_tree/src/logic/map_objects/tribes/militarysite.cc,
line 85.
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Well another solution would be:
We rename the back button to "Leave lobby"
Above the button we have a checkbox "Clear login data"
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands Developers is subscribed to
With this branch I get crashes after a while. Not sure if the culprit is this
branch or something in trunk, though.
/Users/toni/Launchpad/widelands-repo/working_tree/src/graphic/animation.cc:451]
Requested unknown animation with id: -432781024
==54196==ERROR: AddressSanitizer: SEGV on unknown
Your buttons are a little too big. The buttons for in-/decreasing the wares are
24x24 while yours are 25x30.
Also, some wares are covered by the button; see the fish in the tavern (I guess
that is because of your buttons being to big)
--
Four warnings left:
src/logic/playercommand.cc:2288:6: warning: default label in switch which
covers all enumeration values [-Wcovered-switch-default]
default:
src/logic/playercommand.cc:2384:6: warning: default label in switch which
covers all
hmm. I would prefer icons but you are completely right. I opened a topic in the
forum:
https://wl.widelands.org/forum/topic/4518/?page=1#post-27957
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your team Widelands Developers is requested to review
The proposal to merge
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into
lp:widelands has been updated.
Commit message changed to:
redesigned login box
- limit the possible characters for usernames
- draw a red box around the input field for erroneous input
- tell
We have a logout button now :D
The login dialog will be shown only for non registered users. Registered users
may log out from their account from within the lobby.
The additional login button from the Multiplayer menu is removed.
--
I have moved username validation to internet gaming.
I'm currently experimenting with a logout button stay tuned :=)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands Developers is subscribed to branch
Some comments regarding the UI.
I think we should keep the UI consistent. Instead of checkboxes please use the
icons/buttons that are used in the building's window. The same applies for the
priority settings. We use traffic lights instead of buttons.
--
I get these compiler warnings a couple of times.
/Users/toni/Launchpad/widelands-repo/working_tree/src/logic/map_objects/tribes/building_settings.h:42:8:
warning: 'Widelands::BuildingSettings' has virtual functions but non-virtual
destructor [-Wnon-virtual-dtor]
struct BuildingSettings {
=== modified file 'src/ui_fsmenu/internet_lobby.cc'
--- src/ui_fsmenu/internet_lobby.cc 2019-05-13 06:04:34 +
+++ src/ui_fsmenu/internet_lobby.cc 2019-05-15 08:36:30 +
@@ -296,6 +296,8 @@
case kClientSuperuser:
pic =
In trunk admins are written in green in the client list. Did you remove this on
purpose? If not, I'm going to post the patch the next comment,
--
https://code.launchpad.net/~widelands-dev/widelands/font_size-lua/+merge/366938
Your team Widelands Developers is requested to review the proposed
I could think of another option. We remove the button entirely. The login
window is always shown for non registered users. When a user has entered a
password, the dialog won't be shown as long as the password is valid.
--
I made the "show login dialog" button a proper button. kaputtnik has second
thoughts, though.
here is a screenshot:
https://i.ibb.co/b3W3x3W/internetgame.png
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands
Carets are also fixed.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start.
Diff comments:
>
> === modified file 'src/wui/economy_options_window.cc'
> --- src/wui/economy_options_window.cc 2019-02-23 11:00:49 +
> +++ src/wui/economy_options_window.cc 2019-05-11 13:37:58 +
> @@ -186,35 +281,399 @@
> const
Please test again it should address all issues. The only problem is that the
caret does not move properly. Help is appreciated. :)
@Gun have a look at the diff comment, please.
Diff comments:
>
> === modified file 'src/ui_fsmenu/multiplayer.cc'
> --- src/ui_fsmenu/multiplayer.cc
Solved :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367314
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start.
___
And one more. This is the handling of direct messages. I know this is branch is
about fonts but maybe we can address this here.
Do we need:
sender @recepiant: text
For direct messages? The name is already coloured green and the text italic.
This differentiates the message more than enough
On more question. We have 2 different fonts now. The one used in editboxes is
completely different from the other font. Is this intentionally?
--
https://code.launchpad.net/~widelands-dev/widelands/font_size-lua/+merge/366938
Your team Widelands Developers is requested to review the proposed
I got ~100 compile warnings:
src/io/filesystem/filesystem.h:150:71: warning: unknown command tag name
[-Wdocumentation-unknown-command]
/// Returns all files in the given 'directory' that match
'basename[_\d{1,3}].extension'
Review: Approve
Perfect.
--
https://code.launchpad.net/~widelands-dev/widelands/overlapping_workareas/+merge/366623
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/overlapping_workareas.
___
Mailing list:
Well, then.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825932-open-games-clean-start/+merge/367318
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start.
1 - 100 of 441 matches
Mail list logo
