The proposal to merge lp:~widelands-dev/widelands/ai_portspaces into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
--
Your team Widelands Developers is subscribed to branch
Thanks for cleaning up :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list: https://la
I believed the name is the person who should improve the code in the future.
it is removed now :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
Yep :)
No need for the extra ? though, it's supposed to be TODO(tiborb):
The reason for the username is that we will know who created the comment, in
case somebody else will want to fix it later and has a question about the
comment.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_por
Continuous integration builds have changed state:
Travis build 3133. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/337039757.
Appveyor build 2940. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_portspa
The proposal to merge lp:~widelands-dev/widelands/ai_portspaces into
lp:widelands has been updated.
Commit Message changed to:
AI now scans entire map for portspaces. And multiple changes to the logic,
including logic of placing militarysites in vicinity of port spaces.
For more details, see:
Should be OK now... we will see
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list: https://launchpad.ne
That's because CodeCheck is failing, as you can see from the Travis logs:
+grep '^[/_.a-zA-Z]\+:[0-9]\+:' codecheck.out
/home/travis/build/widelands/widelands/src/ai/defaultai.cc:990: Use
"TODO(username): ".
+echo 'You have codecheck warnings (see above) Please fix.'
You have codecheck warnings (
@Gun, this is still not merged
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list: https://launchpad.
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 3117. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/335329642.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widela
Review: Approve
The new AppVeor build worked :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
M
Continuous integration builds have changed state:
Travis build 3117. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/335329642.
Appveyor build 2924. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_portspa
trunk merged, not tested, but there were no conflicts
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list:
I tried the 32 bit version now, no joy.
Can you merge trunk again to trigger a new AppVeyor build? Maybe that will help.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portsp
:(
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to :
I'm having trouble downloading the AppVeyor build where I am, so somebody else
will need to test this.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
OK, I need this (and the other AI branch) so I can resume AI training...
Two considerations:
1.) Some training is still needed to settle the changes
2.) The main problem here is road building, AI tend to build a road over free
space and is insensitive about what fields it is crossing. I was consi
Sure, no problem.
This still needs some testing, I might get around to it next week.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
_
ad 1) OK, I will consider better one
ad 2) I did not know it, I will be more careful next time
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
If you can't think of a better variable name, we can leave it, although it
sounds a bit strange.
bunnybot will also run clang-format on each merge to trunk, so there will be
differences.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Devel
as for clang-format: if I run clang-format over defaultai.cc and merge to
trunk, and re-run it 2 months later, there should not be such differences I
believe. Both clang-formats are run on the same machine...
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your
as for unowned_portspace_vicinity_nearby: some fields are restricted, listed in
ports_vicinity, but here we dont talk about this, but about normal (allowed)
buildable fields, and this is count of such "vicinity fields", so this is
something like second / outer circle of fields around ports...
-
clang-format results are somewhat system-dependent, so results can differ from
what bunnybot will produce. So, you will probably get the same differences the
next time.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed
Those differences came to exist due to clang-format, and I dont understand why
they are there Does rules for clang-format changes over time? but at least
next time I will run clang-format there should not be such differences anymore.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_
Review: Approve
Code LGTM, just a few tiny nits. Not tested.
There were a lot of entries in the diff that don't contain any code changes at
all - please use a merge tool like Meld to compare to trunk the next time this
happens. This will save the reviewer a lot of time.
Diff comments:
> === m
Continuous integration builds have changed state:
Travis build 3036. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/325873487.
Appveyor build 2844. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_portsp
Continuous integration builds have changed state:
Travis build 3031. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/325644451.
Appveyor build 2839. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_portspa
TiborB has proposed merging lp:~widelands-dev/widelands/ai_portspaces into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
AI now scans entire map for portspaces. And m
28 matches
Mail list logo
