Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread Teppo Mäenpää
The appveyor build failed after 31 seconds from start, supposing that that was unrelated to this. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 Your team Widelands Developers is subscribed to branch lp:~widelands-dev

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 -- Your team Wid

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread bunnybot
Continuous integration builds have changed state: Travis build 3111. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/334825498. Appveyor build 2918. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1746030

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread GunChleoc
Review: Approve No worries, shit happens! Let's try bunnybot @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1746030-scout-assert-failur

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread Teppo Mäenpää
Many hours of playtesting (self and network), and then trouble with travis and all and finally SirVer had to do a manual merge (crisscross). Guess how stupid it feels when after all this, all related testgames fail immediately.. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread Teppo Mäenpää
Maybe, this time, we can trust that the if-statement in the preceding line is free of any bugs and those two thus have a similar truth table. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 Your team Widelands Developers is requested to revie

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread GunChleoc
It would be easier to read if we had assert(!scouts_worklist.empty()) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1746030-sco

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread Teppo Mäenpää
Low hanging fruit: It should not take long to conclude that this is an improvement ;-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1746030-scout-assert-failures/+merge/336787 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bu

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands

2018-01-29 Thread Teppo Mäenpää
Teppo Mäenpää has proposed merging lp:~widelands-dev/widelands/bug-1746030-scout-assert-failures into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1746030 in widelands: "Recent scout improvement has assert failures" https://bugs.launchpad.net/wide