[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-20 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 -- Your t

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3791. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415624736. Appveyor build 3590. State: failed. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread hessenfarmer
@ypopezios: In principle you are right. It is somewhat arbitrary or you might say it is try and error. On the other hand I don't know how to handle this in a different way, cause more frequent calls of the working programs will always consume more processing power. so the value of 500 to 1000ms

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread ypopezios
In principle, if I was given a range to compromise with, I would go the conservative route and pick the edge of the range which is closer to the previous value. In this case, the given range is 500 to 1000ms, the previous value is 1ms, so I would go with 1000ms. Having said that, in my

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread Toni Förster
> Looks good from my side now. > Would be good though if somebody with an underpowered machine would confirm > minimal effect on performance Do you think it gets much more underpowered. Your processor is basically the same as mine. Just a few MHz slower. The only difference is RAM. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread hessenfarmer
Review: Approve Looks good from my side now. Would be good though if somebody with an underpowered machine would confirm minimal effect on performance -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-13 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands. Commit message: reduce waiting time to 500ms for skipped programs Requested reviews: hessenfarmer (stephan-lutz) Related bugs: Bug #1786613 in widelands: "production times are