The proposal to merge
lp:~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367
Since the parent branch has been merged, this can go in as well.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367314
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 5034. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/536418869.
Appveyor build 4814. State: failed. Details:
Solved :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367314
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start.
___
There is some code duplication that I'd like to see solved.
Diff comments:
>
> === modified file 'src/ui_fsmenu/netsetup_lan.cc'
> --- src/ui_fsmenu/netsetup_lan.cc 2019-05-11 18:50:30 +
> +++ src/ui_fsmenu/netsetup_lan.cc 2019-05-11 23:08:03 +
> @@ -247,6 +248,24 @@
> }
>
>
Continuous integration builds have changed state:
Travis build 4948. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/531272166.
Appveyor build 4729. State: success. Details:
Review: Approve
This is the same as this one:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names/+merge/367123
The old one got approved but was merged too early. This is the third patch that
needs to go in when the others have been merged
--
The proposal to merge
lp:~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start into
lp:widelands has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+merge/367
The proposal to merge
lp:~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start into
lp:widelands has been updated.
Status: Work in progress => Approved
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+me
The proposal to merge
lp:~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+me
The proposal to merge
lp:~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start into
lp:widelands has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names-clean-start/+me
11 matches
Mail list logo
