The proposal to merge lp:~widelands-dev/widelands/doc_type_name into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
--
Your team Widelands Developers is subscri
Thanks for finishing this up :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/doc_type_name.
___
Mailing list:
This is a test, please ignore.
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/doc_type_name.
___
Mailing list:
Done.
I think this is ready to go now?
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/doc_type_name.
___
Mailing list:
I think that's a good idea and I agree with the phrasing. I won't get to it
before the weekend, would you like to take care of it?
"You cannot instantiate this directly, access it via wl.Game().map.get_field()
instead."
--
Continuous integration builds have changed state:
Travis build 2499. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/259871581.
Appveyor build 2323. State: success. Details:
Nice :-)
I did some additional syntax fixes for wl.map.Warehouse.
There is one issue left from my side:
I the Fields section one could read: "You cannot instantiate this class
directly, instead use wl.map.Map.get_field()." See:
https://wl.widelands.org/docs/wl/autogen_wl_map/#field
The link
Thanks for digging that one up! All linked now :)
I think we still have too much asymmetry between objects and their descr, but
that can't be helped without exposing the rest to the Lua interface, which I'd
say is out of scope for this branch.
--
I get it to work, see http://ibb.co/ecziaQ
If you are fine with my wording i will change the other occurrences according
to this example.
To get this working i just used another "role" called :any:. This searches for
all parts wich has a clickable header in the documents. One could use parts
Continuous integration builds have changed state:
Travis build 2490. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/259384065.
Appveyor build 2314. State: success. Details:
I spent an hour RTFM and it looks like we can't link to MapObject:descr with
Sphinx. I ran out of time, so I'll have to try again some other time. If
somebody else figures this out in the meantime, it won't hurt my feelings :P
--
Continuous integration builds have changed state:
Travis build 2488. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/259145374.
Appveyor build 2313. State: success. Details:
This looks much better now :-)
One nit: There are now several statements like:
"You can access further properties via its descr."
The word 'its' let me assume that 'descr' is a property of the linked objects,
but there is no such property. Maybe clarify the statement to something like:
"You
Review: Resubmit
I have made the documentation more detailed now, added a couple of links and
documented the type hierarchy by linking. Also fixed the bugs that kaputtnik
found.
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is
The proposal to merge lp:~widelands-dev/widelands/doc_type_name into
lp:widelands has been updated.
Commit Message changed to:
Fixed and improved documentation for LuaMapObjectDescription::get_type_name.
More cross-linking between map object classes and their description objects.
Fixed some
That links to how to define a tribe... it would be more useful to have a
reference to the properties that can be queried at runtime in
https://wl.widelands.org/docs/wl/autogen_wl_map/#module-classes, link to class
wl.map.ImmovableDescription etc.
--
> We could link them to the LuaDescription objects,
> which already have documentation about he building types etc.
Don't know what you mean here :-S E.g. this page:
https://wl.widelands.org/docs/wl/autogen_toc_lua_tribes_buildings/ ?
Creating a documentation which is useful for beginners is
We could link them to the LuaDescription objects, which already have
documentation about he building types etc.
No resubmit needed unless you want to send a diff to the mailing list or signal
a big change.
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your
Continuous integration builds have changed state:
Travis build 2476. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/257274323.
Appveyor build 2301. State: success. Details:
Sorry for the extra commit, using this Ubuntu on Win is a pian.
OTOH I build the shinx Docs now, and found my comment there.
Gun: will we need a resubmint?
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is subscribed to branch
Yes, your comment is correct.
We still lack documentation for the world objects, so feel free to add it here.
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/doc_type_name.
Review: Approve review
Since this is no code change there is no sense in compiling this.
All fine foe me, ther mor docs the better.
If my inline comment abot critter is correct I will iclude it.
Diff comments:
>
> === modified file 'src/scripting/lua_map.cc'
> --- src/scripting/lua_map.cc
You're right - I don't know when I gan get to it though.
--
https://code.launchpad.net/~widelands-dev/widelands/doc_type_name/+merge/328006
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/doc_type_name into lp:widelands
:~widelands-dev/widelands/doc_type_name into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net
/~widelands-dev/widelands/doc_type_name/+merge/328006
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/doc_type_name into lp:widelands.
=== modified file 'src/logic/map_objects/map_object.cc'
--- src/logic/map_objects/map_object.cc 2017-06-25
25 matches
Mail list logo
