The proposal to merge lp:~widelands-dev/widelands/ships_optr into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ships_optr/+merge/343292
--
Your team Widelands Developers is subscribed to branch
Regarding the first comment, I simply imitated the fix that SirVer programmed
for the Building Window. After months of trying to fix that thing, using OPtr
is what it finally fixed it. I guess we have some concurrency issues here, i.d.
a delay with handling the notification that the ship is not
Review: Approve
Only looked at the code, do you also want some testing?
Code looks good so far, two comments are in the diff.
Diff comments:
>
> === modified file 'src/wui/shipwindow.cc'
> --- src/wui/shipwindow.cc 2018-04-07 16:59:00 +
> +++ src/wui/shipwindow.cc 2018-04-17
/_widelands_dev_widelands_ships_optr-3193.
--
https://code.launchpad.net/~widelands-dev/widelands/ships_optr/+merge/343292
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ships_optr into lp:widelands.
___
Mailing list: https
/_widelands_dev_widelands_ships_optr-3191.
--
https://code.launchpad.net/~widelands-dev/widelands/ships_optr/+merge/343292
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ships_optr into lp:widelands.
___
Mailing list: https
:~widelands-dev/widelands/ships_optr into lp:widelands.
=== modified file 'src/wui/interactive_gamebase.cc'
--- src/wui/interactive_gamebase.cc 2018-04-07 16:59:00 +
+++ src/wui/interactive_gamebase.cc 2018-04-16 08:10:15 +
@@ -236,7 +236,7 @@
UI::UniqueWindow::Registry& regi
6 matches
Mail list logo
