@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/table_align.
___
Mailing list: https://launchpad.net/~widelands-dev
The proposal to merge lp:~widelands-dev/widelands/table_align into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
--
Your team Widelands Developers is subscribed to bra
Diff comments:
>
> === modified file 'src/ui_basic/table.cc'
> --- src/ui_basic/table.cc 2015-12-31 08:36:41 +
> +++ src/ui_basic/table.cc 2016-01-06 12:13:29 +
> @@ -365,8 +374,25 @@
> text_width = text_width + m_scrollbar->get_w();
>
Review: Approve
some nits. Not sure how to test this though.
Diff comments:
> === modified file 'src/graphic/text/bidi.cc'
> --- src/graphic/text/bidi.cc 2015-10-12 12:11:58 +
> +++ src/graphic/text/bidi.cc 2016-01-06 12:13:29 +
> @@ -555,11 +555,12 @@
> namespace i18n {
>
>
>
The proposal to merge lp:~widelands-dev/widelands/table_align into lp:widelands
has been updated.
Commit Message changed to:
Fixed positioning problems with long table entries and table image alignment
for BiDi languages.
For more details, see:
https://code.launchpad.net/~widelands-dev
/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/table_align into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
The arabic savegame could not be loaded and I attached one screenshot to the
bug...
--
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/table_align
, and game summary
- the editor load/save map windows.
--
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/table_align into lp:widelands
ted to review the proposed merge of
lp:~widelands-dev/widelands/table_align into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More h
code looks good AFAIT, just test it somebody
--
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/table_align into lp:widelands
t is shown on the right if the table
cell is right-aligned.
I have attached a bogus savegame to the bug with a long name in Arabic script
(I don't speak Arabic, so I hope it doesn't say anything offensive :P).
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~wid
11 matches
Mail list logo
