Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-08-09 Thread GunChleoc
Thanks for the review :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-08-08 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 -- Your team Widelands Develop

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-08-08 Thread SirVer
Review: Approve lgtm. This seems like a net simplification to me, which is always great :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-24 Thread kaputtnik
Review: Approve testing Works :-) Opened all windows and found no problems. Should Ken Cunnningham be asked if the initial bug is still fixed for him? Looks like this is complicated stuff... maybe add some comments to the code? --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-24 Thread GunChleoc
Review: Resubmit *headdesk* next try. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-23 Thread kaputtnik
Ah, a debug build shows assertions: Clicking on tab in About: widelands: ../src/ui_basic/tabpanel.cc:313: virtual void UI::TabPanel::draw(RenderTarget&): Assertion `x <= get_w()' failed. Opening Options: widelands: ../src/ui_basic/panel.cc:242: void UI::Panel::set_size(int, int): Assertion

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-23 Thread kaputtnik
Review: Needs Fixing The About page works not correct. When clicking one of the tabs, nothing is shown anymore and the tab bar is cut. Happens also if you click on "Readme". Options window: - The 'background panel(?) (the one where ui elements are placed on), is restricted to the height to fit

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-23 Thread GunChleoc
Review: Resubmit Thanks! Should be fixed now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-23 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands has been updated. Commit Message changed to: Fixed assert failure with sizes in FileViewPanel::layout() and TabPanel. Also, simplified the TabPanel constructor. For more details, see: https

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-18 Thread kaputtnik
Review: Needs Fixing I got a crash when trying to open the buildings statistics menu: widelands: /home/kaputtnik/widelands-repo/bug-1697242-fileview/src/ui_basic/tabpanel.cc:313: virtual void UI::TabPanel::draw(RenderTarget&): Assertion `x <= get_w()' failed. Played in fullscreen with

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 2310. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/243586383. Appveyor build 2143. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 2285. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/242178054. Appveyor build 2120. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-11 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands has been updated. Commit Message changed to: Fixed panel sizes < 0 in FileViewPanel::layout(). Also, simplified the TabPanel constructor. For more details, see: https://code.launchpad.net/~widelands-

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-11 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands has been updated. Commit Message changed to: Fixed panel sizes < 0 in FileViewPanel::layout(). Also, simplified the constructor. For more details, see: https://code.launchpad.net/~widelands-dev/widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-11 Thread GunChleoc
Review: Resubmit The original Bug reporter has tested & confirmed that the fix is working now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-11 Thread Klaus Halfmann
widelands-dev/widelands/bug-1697242-fileview into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-11 Thread GunChleoc
6 I can't reproduce the crash, but this branch will hopefully fix it. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands. === modified file 'src/ui_basic/fileview_panel.cc' --- src/ui_basic/fileview_panel.