Review: Needs Fixing
Diff comments:
>
> === modified file 'utils/buildcat.py'
> --- utils/buildcat.py 2015-11-06 18:57:00 +
> +++ utils/buildcat.py 2015-11-27 17:43:13 +
> @@ -58,8 +58,9 @@
> "../../world/*/*/*/*/*/*.lua",
> ]),
> ("tribes/tribes", [
> -
see inline comments
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list:
Yes, that fixed it :)
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list:
Thanks :)
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Review: Approve
lgtm. gonna merge.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/hide_seafaring_buildings into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/hide_seafaring_buildings/+merge/278830
--
Your team Widelands Developers
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1502965 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1502965 in widelands: "Building statistics window does not "courtain up"
correctly"
The proposal to merge lp:~widelands-dev/widelands/bug-1509791 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1509791/+merge/278243
--
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
--
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/bug-1519361 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1519361/+merge/278886
--
Your team Widelands Developers is subscribed to branch
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1519361 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1519361 in widelands: "PlayerColor in Building menu causes render errors"
https://bugs.launchpad.net/widelands/+bug/1519361
Review: Approve
lgtm. but I did not test it yet.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1519361/+merge/278886
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1519361.
___
Mailing list:
Review: Approve
Thumbs up :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1520762/+merge/278893
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1520762.
___
Mailing list:
Review: Needs Fixing
But I dont think it is correct, providing that m_items is bigger then 1 and it
contains various wares - count should be either sum of all item_pair.second
(see comment of diff) or rather the result string should be in format
warename+count and should be generated
You are right, we need to sum these up.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1520820/+merge/278898
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1520820.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/bug-1520762 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1520762/+merge/278893
--
Your team Widelands Developers is subscribed to branch
Thanks, fix pushed to trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1520762/+merge/278893
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1520762.
___
Mailing list:
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1520762 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1520762 in widelands: "Error in defaultai.cc"
https://bugs.launchpad.net/widelands/+bug/1520762
For more details, see:
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1520820 into
lp:widelands.
Requested reviews:
Tino (tino79)
Related bugs:
Bug #1520820 in widelands: "trunk 7650 fails to compile on gcc 5.2.0"
https://bugs.launchpad.net/widelands/+bug/1520820
For more details, see:
19 matches
Mail list logo
