Continuous integration builds have changed state:
Travis build 1684. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/180634980.
Appveyor build 1524. State: failed. Details:
The proposal to merge lp:~widelands-dev/widelands/bug-collectors into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-collectors/+merge/312092
--
Your team Widelands Developers is subscribed to
Continuous integration builds have changed state:
Travis build 1682. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/180521653.
Appveyor build 1522. State: success. Details:
Review: Approve
lgtm, but one comment:
// If this isn't here, we get a compiler warning in Windows. If it is, we get a
compiler
// warning in clang. There is no natural default for this function.
Maybe we should tweak our warnings instead of changing the code. All our
warning definitions are
> Can this be added to the bunnybot merge command once we have this in trunk?
> I'm thinking bzr merge, clang-format, bzr commit here.
Yes, it probably can. If I can figure out how to install clang-format on the
buildbot. I'll have a look.
A couple of nits inlined.
Diff comments:
> === added
Character encoding is so not fun :(
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix_map_upload/+merge/312300
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
6 matches
Mail list logo