Review: Resubmit
The original Bug reporter has tested & confirmed that the fix is working now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1697242-fileview.
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into
lp:widelands has been updated.
Commit Message changed to:
Fixed panel sizes < 0 in FileViewPanel::layout(). Also, simplified the
constructor.
For more details, see:
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1697242-fileview
into lp:widelands.
Commit message:
Changed break condition in FileViewPanel::layout() to fix an assertion failure
with negative sizes. Also, simplified the constructor.
Requested reviews:
Widelands Developers
It isn't shown by the diff below, but `.travis.sh` installs `libboost-all-dev`,
which is a metapackage to install all boost components. This is likely the
reason why this wasn't discovered until merged to trunk, since the Debian
packaging is more minimal and only list the required components.
Code is OK, but I got this assertion:
Assertion failed: (nh >= 0), function set_size, file
.../bug-1697242-fileview/src/ui_basic/panel.cc, line 242.
Abort trap: 6
but was unable to reproduce this :\
I think it was opening the about window after switching to fullscreen?
ON OSX we have the extar
5 matches
Mail list logo
