Thanks for the review :)
I think it's a separate issue, so I have created a new bug report:
https://bugs.launchpad.net/widelands/+bug/1748855
I have assigned you, but do feel free to unassign yourself.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-empire2/+merge/33
The proposal to merge lp:~widelands-dev/widelands/fh1-empire2 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-empire2/+merge/336850
--
Your team Widelands Developers is requested to review the
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-tutorial3 into
lp:widelands.
Commit message:
Converted Tutorial 3 to new font renderer
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-tutorial
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-documentation
into lp:widelands.
Commit message:
Updated documentation for new font renderer
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-do
The proposal to merge lp:~widelands-dev/widelands/fh1-documentation into
lp:widelands has been updated.
Commit Message changed to:
Documented tag constraints for new font renderer
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-documentation/+merge/337545
--
Your
The send_to_all function change is from
https://code.launchpad.net/~widelands-dev/widelands/fh1-maps-multiplayer/+merge/337506,
so that branch needs to be merged first.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-documentation/+merge/337545
Your team Widelands Developers is reques
Thanks for cleaning up :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_portspaces.
___
Mailing list: https://la
Review: Approve
Code LGTM, will do some testing.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_numbers_expansion/+merge/337124
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_numbers_expansion.
___
Mai
The proposal to merge lp:~widelands-dev/widelands/ai_portspaces into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_portspaces/+merge/335785
--
Your team Widelands Developers is subscribed to branch
Tested.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_numbers_expansion/+merge/337124
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_numbers_expansion.
___
Mailing list: https://launch
Review: Approve
LGTM - thanks for following up :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1744583_fix_building_help/+merge/337509
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1744583_fix_building_help.
___
Thanks
As soon as findpath branch is merged, I will resume training and hope soon
deliver new version of wai files
--
https://code.launchpad.net/~widelands-dev/widelands/ai_numbers_expansion/+merge/337124
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_numb
The proposal to merge lp:~widelands-dev/widelands/bug-1744583_fix_building_help
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1744583_fix_building_help/+merge/337509
--
Your team Widelands De
The proposal to merge lp:~widelands-dev/widelands/ai_numbers_expansion into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_numbers_expansion/+merge/337124
--
Your team Widelands Developers is subscr
Continuous integration builds have changed state:
Travis build 3168. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/340441956.
Appveyor build 2975. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_documen
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1639514_fix_yellow_player/+merge/337507
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_infrastructure_return_values.
__
You lost the localization markup in the elemental packet. This happens because
our profile class doesn't support saving that when you update a map.
Having desyncs is fine, we do not guarantee multiplayer compatibility between
versions.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-
Various small code style nits. There is 1 loop that I'm worried about - can you
please revisit the code there and add an explicit break condition, and/or a
comment?
Diff comments:
> === modified file 'src/ai/ai_help_structs.cc'
> --- src/ai/ai_help_structs.cc 2017-11-24 09:19:52 +
> +++ src
Took the freedom to adjust the RST parts. Mainly:
- make lists of allowed attributes a bulleted list (i think this was intended)
- fixed some args
- fixed indentation to have it consistent over the pages
- added the function definition of new_objectives() in richtext_scenarios.lua
- added some lin
Thanks :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1639514_fix_yellow_player/+merge/337507
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_infrastructure_return_values.
___
Mailing list: https:/
Continuous integration builds have changed state:
Travis build 3169. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/340443107.
Appveyor build 2976. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_tutori
Gun,
your suggestion about NearFlag constructor is failing with:
no matching function for call to ‘Widelands::NearFlag::NearFlag(std::nullptr_t,
int)’
Also in regard to (;;) I changed a comment few lines bellow it to be obvious
where the looping ends:
"OK, so no NearFlag left to be checked -
Continuous integration builds have changed state:
Travis build 3173. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/340643220.
Appveyor build 2980. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_docume
The constructor failed because you were initializing with a reference in the
other constructor. I have changed that to a pointer, since the object has a
pointer internally anyway.
For the loop, it's not clear to me how the loop above the end condition
actually ensures that eventually there's no
24 matches
Mail list logo
