Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_fisher_fix into lp:widelands

2018-04-07 Thread GunChleoc
Review: Approve LGTM - just 1 nit for a comment. Please merge once it's fixed :) Diff comments: > > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2018-04-02 08:44:26 + > +++ src/ai/defaultai.cc 2018-04-06 10:10:52 + > @@ -1471,10 +1471,23 @@ >

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-07 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands. Commit message: Building Statistics now only show relevant buildings - Military sites not belonging to the tribe are omitted, unless the payer currently owns one - Seafaring and allowed buil

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-07 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands has been updated. Commit message changed to: Building Statistics now only show relevant buildings - Military sites not belonging to the tribe are omitted, unless the payer currently owns one - Seafar

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands

2018-04-07 Thread GunChleoc
Trivial, just running it through bunnybot to be on the safe side. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/update_copyright_to_2018/+merge/342829 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/update_copyright

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands

2018-04-07 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands. Commit message: Tweaking scoring of AI performance, used for training of AI. No effect on gameplay altogether. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_fisher_fix into lp:widelands

2018-04-07 Thread TiborB
OK, fixed, merging now @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_fisher_fix/+merge/342427 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_fisher_fix. ___ Mailing list: https://launch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands

2018-04-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3356. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/363551728. Appveyor build 3162. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_update_cop

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands

2018-04-07 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 3356. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/363551728. -- https://code.launchpad.net/~widelands-dev/widelands/update_copyright_to_2018/+merge/342829 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3357. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/363552376. Appveyor build 3163. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_smaller_bu

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands

2018-04-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3358. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/363583953. Appveyor build 3164. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_scoring