Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-08 Thread Klaus Halfmann
Some more commetns inline, I think this deserves some time in the debugger. Mostly for me to better understand the widelands internal structures. Maybe this will make things slower, Not sure about this, lets seee. Diff comments: > > === modified file 'src/wui/building_statistics_menu.cc' > ---

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands

2018-04-08 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/update_copyright_to_2018/+merge/342829 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-08 Thread Klaus Halfmann
One question inline, will take a closer look later. just brached this and will have a look. Not sure who will be the payer for the other tribes military sites ;-) ? Diff comments: > > === modified file 'src/ui_basic/tabpanel.cc' > --- src/ui_basic/tabpanel.cc 2017-08-08 17:39:40 + > +++

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands

2018-04-08 Thread GunChleoc
Transient failure on Travis. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/update_copyright_to_2018/+merge/342829 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/update_copyright_to_2018 into lp:widelands.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands

2018-04-08 Thread GunChleoc
Review: Approve Just 1 code style nit. can go in when it's fixed. Diff comments: > === modified file 'src/ai/ai_help_structs.cc' > --- src/ai/ai_help_structs.cc 2018-04-06 08:14:17 + > +++ src/ai/ai_help_structs.cc 2018-04-07 19:32:15 + > @@ -565,33 +565,28 @@ >

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_fisher_fix into lp:widelands

2018-04-08 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_fisher_fix into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_fisher_fix/+merge/342427 -- Your team Widelands Developers is subscribed to

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands

2018-04-08 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands. Commit message: New WAI files for AI, with a tiny update in C++ code of AI. Requested reviews: Widelands Developers (widelands-dev) For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands

2018-04-08 Thread TiborB
fixed @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_scoring_update/+merge/342831 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_scoring_update. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands

2018-04-08 Thread GunChleoc
Review: Approve LGTM :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_08042018/+merge/342840 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_new_wai_files_08042018. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands

2018-04-08 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_scoring_update into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_scoring_update/+merge/342831 -- Your team Widelands Developers is subscribed

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands

2018-04-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 3363. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/363860891. Appveyor build 3169. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands

2018-04-08 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_new_wai_files_08042018 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_08042018/+merge/342840 -- Your team Widelands