Added inline comment.
Diff comments:
>
> === modified file 'src/ui_fsmenu/launch_spg.cc'
> --- src/ui_fsmenu/launch_spg.cc 2018-07-07 20:22:12 +
> +++ src/ui_fsmenu/launch_spg.cc 2018-08-26 11:35:09 +
> @@ -283,7 +283,14 @@
> Widelands::PlayerNumber const nrplayers =
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into
lp:widelands.
Commit message:
Fixes for Debian-based software centers
- Add stock icon to appdata.xml (c.f.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857644)
- Change icon
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center/+merge/353752
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into
lp:widelands.
The proposal to merge
lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into
lp:widelands has been updated.
Commit message changed to:
Fixes for Debian-based software centers
- Add stock icon to appdata.xml (c.f.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857644)
-
Changes are done. Could you please retest to make sure that I haven't missed
anything?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1783878_editor_random_map_tribe/+merge/352943
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 3836. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/420887444.
Appveyor build 3634. State: success. Details:
Continuous integration builds have changed state:
Travis build 3837. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/420887783.
Appveyor build 3635. State: success. Details:
The proposal to merge
lp:~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1789023-fix-icon-for-software-center/+merge/353752
--
military route tested as well. no anomalies found.
--
https://code.launchpad.net/~widelands-dev/widelands/empire04_bug_fix_enhance/+merge/353742
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/empire04_bug_fix_enhance into lp:widelands.
Review: Approve compile, review, test,
Works for me,
I cannot judge mutch abouthe the code.
ypopezios: you are correct, but lets get rid of the bug first
and do the improvement in some second step.
Gun: will we need a resubmit before wer can merge this?
@bonnybot merge
--
@ypopezios: Good idea, but not as easy as it sounds - when set to "random", the
tribe is already sneakily assigned in the background so that the user can
choose an initialization ("Headquarters") etc. So, removing that extra variable
has a lot of other implications in the code as well and is
11 matches
Mail list logo
