Thanks for the excellent review :)
I have addressed most of your comments and left replies to the rest.
One of our math wizards spent a long time tweaking the system and the function,
so I'm hesitant to change any semantics here. There is an e function involved,
so there is no way to avoid
Cleaning up unused stuff is always a good idea :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/remove_djangoratings/+merge/358960
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
thanks Arty for your comments and solutions. I would be happy to test this
again after the fixes.
Nice spot with the resulting farm1 issue after this finally works.
Diff comments:
>
> === modified file 'data/campaigns/emp04.wmf/scripting/tribes/farm1.lua'
> ---
Continuous integration builds have changed state:
Travis build 4263. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/458376614.
Appveyor build 4057. State: success. Details:
Review: Approve
Perhaps it might be worth having it without the string . (showing nothing
beneath the Headings)
--
https://code.launchpad.net/~widelands-dev/widelands/empire04_unused_key_return_on_dismantle/+merge/358273
Your team Widelands Developers is subscribed to branch
Yes, the exponential function is the problem. Approximating it with highish
precision using only integer calculations would require a lot of computation,
which isn't really feasible. There are reasonable options though if we don't
mind straying a little. The function we use here is basically a
Tested the branch. Works like it should do. no difference found in empire 04.
ALthough the message for no wares returned looks unfamiliar and is to long for
my taste.
For me we should have the same headings as for wares returned. and a short
message like "no wares" instead of the waremap to
Continuous integration builds have changed state:
Travis build 4264. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/458580181.
Appveyor build 4058. State: failed. Details:
Review: Approve
Tested and all good now :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/handling-various-fs-errors/+merge/358767
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/handling-various-fs-errors.
The proposal to merge lp:~widelands-dev/widelands/handling-various-fs-errors
into lp:widelands has been updated.
Commit message changed to:
Improved error handling for file save dialogs
For more details, see:
The proposal to merge lp:~widelands-dev/widelands/handling-various-fs-errors
into lp:widelands has been updated.
Commit message changed to:
Improved error handling for file save dialogs
In Load/Save menu for games/replays:
- All deletion errors are caught, player gets a message.
- When
11 matches
Mail list logo
