The proposal to merge
lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1721121-workers-invisible-wares/+merge/343272
--
Your team
Thanks for the review - fixes applied :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1721121-workers-invisible-wares/+merge/343272
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares.
_
Review: Approve diff, testing
If I am not mistaken, this mostly just moves code around, right?
The lost wares are back and the code is looking good so in my opinion this can
go in.
If you want to: two small nits regarding the documentation.
Diff comments:
>
> === modified file 'src/logic/map_o
Continuous integration builds have changed state:
Travis build 3376. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/366705865.
Appveyor build 3182. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_172112
The proposal to merge
lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into
lp:widelands has been updated.
Commit message changed to:
Restored ware hotspot and animation to workers. Made some variables in
WorkerDescr private and/or const.
For more details, see:
https://code.lau
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into
lp:widelands.
Commit message:
Restored ware hotspot to workers. Made some variables in WorkerDescr private
and/or const.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
6 matches
Mail list logo
