Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-24 Thread GunChleoc 
Review: Approve

Let's just have it, so people can use this to play around with the Frisians' 
Lua files.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/ai_2_new_hints.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-04 Thread GunChleoc 
Yep, a switch is even better :)
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-03 Thread TiborB 
Partially reworked and simplified, but without use of std::map
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-02 Thread GunChleoc 
Since we now have the same code repeated three times, how about having a 
function:

BuildingHints::get_ai_limit(Widelands::AiType) const;

And stick the limits in a std::map?
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp