@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition.
_
Let's wait for
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
and then merge when Travis goes green.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribe
Mhh, travis had no sucess with any instalaltions, but did not actually compile
anything on linux.
Gun: can this go in anyway or shall we resubmit this?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is
I have fixed the disappearing work area when a construction site finishes, so
this can go in now. Thanks for the review and for tracking down the bug :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelan
We need to keep is_warping_, otherwise we will get strange behaviour with the
preview disappearing when a building finishes construction.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribed to b
I still have no idea what is_warping_ actually means :-).
It was my best idea to leave the original code there while fixing the bug.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribed to branch
Why did you change if (!is_warping_) to if (showing_workarea_)? The
!is_warping_ check is there for a reason. Maybe you need if (!is_warping_ &&
showing_workarea_)?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands D
Review: Resubmit
I assume this bug was there since perhaps R18 but can only be found with ASAN.
Now I need someone else for the review.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribed to bra
reproducing was (to) easy, just clik on the workarea button and right click
immideatley after that.
Problem is that ~BuildingWindow() calls hide_workarea(); calling
configure_workarea_button()
whhich tries to change the tooltip of the already deleted button.
I can provide a quick fix which woul
> This smells like trying to set a tooltip for some already freed button?
Looks like, it, yes. I can't hunt this one down in a text editor though, so if
you want to give this a try, please do - start with the wui/buildingwindow.cc
class :)
* I am actually used to see the workarea when opening t
Review: Needs Fixing
I will try to merge trunk, which contains a workaroud for #1784200.
Until then I wont be able to debug this any further :\
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribe
Now Internetgaming fails me with
InternetGaming: logout(Something went wrong: Syntax error at 1:385: expected an
allowed tag, got '/p'. String continues with: '
Welcome on the Widelands Metase')
libc++abi.dylib: terminating with uncaught exception of type
RT::SyntaxErrorImpl: Syntax error at 1:3
Some notes:
* logs show:
[] Section [global], key 'workareapreview' not used (did you spell the name
correctly?)
This is actually expected. But will only affect existing games.
* I am actually used to see the workarea when opening the building window,
the extra click now kind of annoys me. e.g.
Review: Needs Fixing testplay, crash
Opps, I got some nasty crash here (Playing Frisians on checkmate)
ERROR: AddressSanitizer: heap-use-after-free on address 0x6130010ce6e1 at pc
0x00010c887b02 bp 0x7ffee7d7d2f0 sp 0x7ffee7d7ca90
WRITE of size 14 at 0x6130010ce6e1 thread T0
#0 0x10c887b01 i
Automatic builds are OK, I do not expect problems with local builds,
will do some testplay (OS-X only) to check for unexpected optical effects or
worse.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is
Thanks for the review :)
I hope it will compile again now - if it doesn't, I'd be happy if you could fix
it for me. I'm still on the VM right now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subsc
Review: Needs Fixing review, compile
Going to compile and tesplay this now ...
For the Review I find:
* Renamed: show_work_area -> show_workarea, Same for hide_work_area ->
hide_workarea
* Option show_workarea_preview_ / "Show buildings area preview" removed
* "workareapreview" not checked any l
17 matches
Mail list logo
