@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1802629-territorial-crash.
___
Mailing
I have tested territorial time intensively
I won on crater (2 players) - everything ok.
I lost after 4 hours on crater - everything ok.
I lost by P2 winning - Game ended after p2 (AI) had more than 50% of the map
plus 20 minutes.
I lost by loosing my HQ - Game ended due to just one player
Review: Approve code
Code LGTM - we should test again to see if we can still reproduce a crash
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227
Your team Widelands Developers is subscribed to branch
Review: Resubmit
ok I fixed all bugs in both win conditions.
the trick was to always calculate the score for all players and only report
result for every player when the game is finished, while using the Game players
(plrs) to count if only one opponent is left (same as autocrat)
this leads to
did some testing
I probably found a solution and will test it tonight.
If testing goes well I will push a new revision of the branch
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227
Your team Widelands Developers is subscribed to branch
I think I know what is going on why it doesn't end. The game over message is
probably correctly triggered, but the message get sent only to the Players
remaining in the players table. as we check for player defeated the defeated
players are removed from the players table and don't get the
good news is it doesn't crash anymore.
Bad news ia it doesn't end anymore (at least not after 4 hours).
I suspect the check for defeated player function in multiple routines removing
all players from the players table.
perhaps we should remove them from all functions and see what happens.
--
ok. I will test this tonight.
But this I somehow weird, cause I wasn't anytime the winning player in the
whole game which crashed.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227
Your team Widelands Developers is subscribed to branch
Should be fixed now
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1802629-territorial-crash.
___
Mailing list:
Review: Needs Fixing
Ok did some playtesting. Won a territorial lord match which was quite fine all
messages were as excepted.
played a territorial time as well. Intentionally I lost the game around 3
hours. Game lost message was in the message box. with the message to be given
at 3:30h I got
10 matches
Mail list logo
