Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
@bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
I have tested territorial time intensively I won on crater (2 players) - everything ok. I lost after 4 hours on crater - everything ok. I lost by P2 winning - Game ended after p2 (AI) had more than 50% of the map plus 20 minutes. I lost by loosing my HQ - Game ended due to just one player remaining I tested even a 3 player setup on two frontiers I lost my HQ and the game ended after one of the AI players had more than 50% of the map plus 20 minutes. The only thing in the current setup is that the Game status is reported at the end so my early loss in two frontiers was not reported. Theoretically it is possible as well to win while defeated by still holding more than 50 % of the map, unless there is only one player left. I was not able to provoke a crash even though I removed most of the safety nets introduced in previous versions of this branch. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
Review: Approve code Code LGTM - we should test again to see if we can still reproduce a crash -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
Review: Resubmit ok I fixed all bugs in both win conditions. the trick was to always calculate the score for all players and only report result for every player when the game is finished, while using the Game players (plrs) to count if only one opponent is left (same as autocrat) this leads to the behaviour that always the game end time reported for all players losing the game, as it is only finally lost when it is over. furthermore in a multiplayer setup it might be possible to win while defeated, but this is how the win condition should be in my eyes. If this is not wanted it could be changed easily. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
did some testing I probably found a solution and will test it tonight. If testing goes well I will push a new revision of the branch -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
I think I know what is going on why it doesn't end. The game over message is probably correctly triggered, but the message get sent only to the Players remaining in the players table. as we check for player defeated the defeated players are removed from the players table and don't get the message anymore. so we could try to use wl.Game().players instead in the game over message -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
good news is it doesn't crash anymore. Bad news ia it doesn't end anymore (at least not after 4 hours). I suspect the check for defeated player function in multiple routines removing all players from the players table. perhaps we should remove them from all functions and see what happens. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
ok. I will test this tonight. But this I somehow weird, cause I wasn't anytime the winning player in the whole game which crashed. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
Should be fixed now -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1802629-territorial-crash into lp:widelands
Review: Needs Fixing Ok did some playtesting. Won a territorial lord match which was quite fine all messages were as excepted. played a territorial time as well. Intentionally I lost the game around 3 hours. Game lost message was in the message box. with the message to be given at 3:30h I got the following error while only having 1 sentry left: [../src/scripting/lua_errors.cc:22] [string "scripting/win_conditions/territorial_function..."]:159: attempt to index a nil value (field '?') -- https://code.launchpad.net/~widelands-dev/widelands/bug-1802629-territorial-crash/+merge/359227 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1802629-territorial-crash. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
