https://bugzilla.wikimedia.org/show_bug.cgi?id=25941

           Summary: Enhanced recent changes clobbers classes
           Product: MediaWiki
           Version: 1.17-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: Javascript
        AssignedTo: d...@ucsc.edu
        ReportedBy: orangepickl...@googlemail.com
                CC: tpars...@wikimedia.org


Created attachment 7819
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=7819
patch detailed in description

Instead of adding/removing classes from elements, toggleVisiblity in
enhancedchanges.js sets the full class attribute.  This conflicts with any
third-party scripts that might set their own classes (and it was in writing
such a script that I came across this).

I've attached a patch for skins/common/enhancedchanges.js, which fixes this for
the #mw-rc-subentries- elements - I think it unlikely you'd need to mess with
the arrows' classes, but fixing them is as easy.  Maybe it would also make
sense to use similar RexEx to test for the arrow's class instead of
"openarrow.className == 'mw-changeslist-expanded'"?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to