https://bugzilla.wikimedia.org/show_bug.cgi?id=26904
Summary: WhatLinksHere only lists image link or transclusion,
never both.
Product: MediaWiki
Version: 1.18-svn
Platform: All
URL: http://commons.wikimedia.org/w/index.php?title=Special
%3AWhatLinksHere&target=File%3AExample.svg&namespace=2
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: Special pages
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: krinklem...@gmail.com
The three foreach() loops here:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l188
overwrite eachother. That was done to avoid duplicates. However the props are
also overwritten.
Perhaps a check to see if it's been set already should be done and merge the
is_template/is_image props.
Although we could choose to let one count stronger than the other (in this case
imagelink, over templatelink, over pagelink) however the following code is
clearly designed with the scenario in mind that multiple props could be set to
1:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l292
<pre>
298 if ( $row->is_template )
299 $props[] = $msgcache['istemplate'];
300 if( $row->is_image )
301 $props[] = $msgcache['isimage'];
302
303 if ( count( $props ) ) {
304 $propsText = '(' . implode(
$msgcache['semicolon-separator'], $props ) . ')';
305 }
</pre>
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
