https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #10 from Jarry1250 2011-03-19 10:30:54 UTC ---
Duplicatebug: That would be slightly more appropriate, agreed. However, since
ChangesList isn't really set up for that, I think that may be the case of
moving from one imperfect solutio
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
p858snake changed:
What|Removed |Added
Keywords|need-review |reviewed
--
Configure bugmail: https://bu
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
Mark A. Hershberger changed:
What|Removed |Added
Status|NEW |RESOLVED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #8 from duplicate...@googlemail.com 2011-03-18 20:01:51 UTC ---
Sorry, the diff is shown very small on my screen.
Maybe use ChangesList::isDeleted instead of creating a new Revision object.
--
Configure bugmail: https://bugzilla.w
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #7 from Jarry1250 2011-03-17 19:37:03 UTC ---
That's what I'm using in the patch :)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the C
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #6 from duplicate...@googlemail.com 2011-03-17 18:06:57 UTC ---
recentchanges table has a rc_deleted field, which should work here.
http://www.mediawiki.org/wiki/Manual:Recentchanges_table#rc_deleted
--
Configure bugmail: https://
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #5 from Jarry1250 2011-03-16 22:54:38 UTC ---
Oh, and no, Revision::construct() takes a database query result as a possible
input (or an array, as here), it does not run its own, AFAICT.
--
Configure bugmail: https://bugzilla.wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
Jarry1250 changed:
What|Removed |Added
Attachment #8302|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #3 from Bryan Tong Minh 2011-03-16
22:07:27 UTC ---
I haven't looked in detail to the code, but I think you need to move the
construction of the Revision object higher up so that you can also hide
rc_user_text.
Also check whether
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
Jarry1250 changed:
What|Removed |Added
Attachment #8301|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
Jarry1250 changed:
What|Removed |Added
Keywords||need-review, patch
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
--- Comment #1 from Jarry1250 2011-03-16 21:55:46 UTC ---
Created attachment 8301
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8301
Functional patch v1
A nice little patch to fix this. Slightly hackish, I suppose, but neat and
functi
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
p858snake changed:
What|Removed |Added
CC||p858sn...@gmail.com
Component|Rec
https://bugzilla.wikimedia.org/show_bug.cgi?id=27899
Bryan Tong Minh changed:
What|Removed |Added
CC||bryan.tongm...@gmail.com
S
14 matches
Mail list logo