https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Keywords|patch, patch-need-review|
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #23 from Krinkle 2012-08-24 14:07:19 UTC ---
Created attachment 10995
--> https://bugzilla.wikimedia.org/attachment.cgi?id=10995
It now has a proper border.
Fixed indeed.
--
Configure bugmail: https://bugzilla.wikimedia.org/use
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Attachment #8488|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Attachment #8489|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Attachment #8490|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Attachment #8491|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #22 from Mark A. Hershberger 2012-08-18
16:02:46 UTC ---
According to the screenshots posted by krinkle, this dialog now looks like
attachment 8489 in comment 7 -- so, fixed? Kind of looks like wikilove is
fixed, too, but I'm no
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Sumana Harihareswara changed:
What|Removed |Added
CC||suma...@wikimedia.org
--- Comme
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #20 from Krinkle 2012-01-02 15:42:26 UTC ---
Reminder for after this bug is fixed:
(Citing bug 29615 comment #4)
> We overrode the black to blue in the WikiLove CSS. I'm going to go ahead and
> mark this as a duplicate, but we need
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Ryan Kaldari changed:
What|Removed |Added
CC||b...@mzmcbride.com
--- Comment #19 from
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Ryan Kaldari changed:
What|Removed |Added
Blocks||29615
--
Configure bugmail: https://bu
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #18 from Ryan Kaldari 2011-06-15 20:15:31
UTC ---
I would suggest that we do whatever the jQuery UI skins do regarding link
styling. Unfortunately, I'm full time on fundraising now, so I don't have any
time to work on this.
--
Co
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Mark A. Hershberger changed:
What|Removed |Added
Priority|Highest |Normal
--
Configure bugmail: ht
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Niklas Laxström changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #15 from DieBuche 2011-05-04 10:25:21 UTC ---
(In reply to comment #14)
> I don't think regular jQuery skins do anything to link colours, as it should
> be.
They do. But obviously only for links inside jui stuff
--
Configure bugm
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
p858snake changed:
What|Removed |Added
Keywords||need-review, patch
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #14 from Niklas Laxström 2011-05-04
07:34:58 UTC ---
(In reply to comment #12)
> I now do ;) Links are used many places (menus) where they shouldn't look like
> links. Reverted
Can the menus be fixed then instead of breaking every
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #13 from Ryan Kaldari 2011-05-03 21:35:50
UTC ---
What do the regular jQuery UI skins do for link coloring? Maybe we should just
match one of them (I think our skin is very loosely based on the Cupertino
skin, BTW).
--
Configure
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #12 from DieBuche 2011-05-03 21:27:38 UTC ---
(In reply to comment #9)
> Link color fixed in r87345. No idea what the original motivation behind this
> was.
I now do ;) Links are used many places (menus) where they shouldn't look l
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #11 from Ryan Kaldari 2011-05-03 20:27:14
UTC ---
Created attachment 8491
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8491
Patch for above implementation
Here's the patch for the implementation above, if that seems good
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #10 from Ryan Kaldari 2011-05-03 20:22:02
UTC ---
Created attachment 8490
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8490
new suggestion for dialog styling
Just added a new attachment based on my ideas above. What do y
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
DieBuche changed:
What|Removed |Added
CC||diebu...@gmail.com
--- Comment #9 from DieB
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #8 from Ryan Kaldari 2011-05-03 19:01:39
UTC ---
Meh. Doesn't look as clean, in my opinion. What if we added the outside border
(without padding) and changed the title border to be border-bottom only?
Are you planning on adding th
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #7 from Krinkle 2011-05-03 18:34:26 UTC ---
Created attachment 8489
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8489
Example of what a modal dialog looks like in this context (proposed
work-around)
Example of what a moda
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #6 from Krinkle 2011-05-03 18:33:48 UTC ---
Created attachment 8488
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8488
Proposed fix: Adding back the 0.2em padding and the border for dialog
--
Configure bugmail: https://bu
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #5 from Krinkle 2011-05-03 18:32:15 UTC ---
Created attachment 8487
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8487
Reproduced the bug: Non-modal dialog. Bug: No border, no visisble edge, bad
accessibility/usability/
Re
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Mark A. Hershberger changed:
What|Removed |Added
Keywords|triage |
Priority|Normal
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #3 from Ryan Kaldari 2011-05-02 20:19:59
UTC ---
It looks like the border issue might be a bit deeper than I thought. We're
actually removing the border around all jQuery UI elements, not just dialogs.
This seems to be an actual de
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
--- Comment #2 from Ryan Kaldari 2011-05-02 19:48:28
UTC ---
I noticed the link color got changed from blue to black recently. We should
probably change that back.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Ryan Kaldari changed:
What|Removed |Added
CC||rkald...@wikimedia.org
--- Comment #1 f
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Krinkle changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Mark A. Hershberger changed:
What|Removed |Added
Keywords||triage
--
Configure bugmail: ht
https://bugzilla.wikimedia.org/show_bug.cgi?id=28690
Mark A. Hershberger changed:
What|Removed |Added
Priority|Unprioritized |Normal
CC|
34 matches
Mail list logo
