https://bugzilla.wikimedia.org/show_bug.cgi?id=29328

       Web browser: ---
             Bug #: 29328
           Summary: jquery.textSelection in core hardcodes checks for
                    WikiEditor's iframe
           Product: MediaWiki
           Version: 1.19-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Javascript
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: br...@wikimedia.org
                CC: tpars...@wikimedia.org
    Classification: Unclassified


While trying to figure out how to better integrate CodeEditor (w/ Ace editing
widget) into WikiEditor based on the existing iframe mode, I found that there's
some WikiEditor-specific hardcoding still in the jquery.textSelection module:

  var context = $(this).data( 'wikiEditor-context' );
  var hasIframe = typeof context !== 'undefined' && context && typeof
context.$iframe !== 'undefined';
  // ...
  retval = ( hasIframe ? context.fn : fn )[command].call( this, options );

It looks like for now, to work with $.textSelection I'll have to pretend to be
the WikiEditor iframe plugin. Ideally we probably want something that's not
specific to WikiEditor, so it can be used on any textarea-alike that can
provide some sort of context functions for the textSelection plugin.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to